Skip to content

Add ArgumentOutOfRangeException.ThrowIf{Not}Equal - #83853

Merged
stephentoub merged 4 commits into
dotnet:mainfrom
stephentoub:aoorethrowequal
Apr 6, 2023
Merged

Add ArgumentOutOfRangeException.ThrowIf{Not}Equal#83853
stephentoub merged 4 commits into
dotnet:mainfrom
stephentoub:aoorethrowequal

Conversation

@stephentoub

@stephentoubstephentoub commented Mar 23, 2023

Copy link
Copy Markdown
Member

Fixes#82667

@ghost

ghost commented Mar 23, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@stephentoubstephentoub changed the title Add AOORE.ThrowIf{Not}EqualAdd ArgumentOutOfRangeException.ThrowIf{Not}EqualMar 23, 2023
@build-analysisbuild-analysisBot mentioned this pull request Mar 24, 2023
Closed
xtqqczze
xtqqczze reviewed Mar 24, 2023
View reviewed changes
Comment threadsrc/libraries/System.Linq.Expressions/src/System/Dynamic/DynamicMetaObjectBinder.cs Outdated
@BrennanConroyBrennanConroy mentioned this pull request Apr 3, 2023
Merged
@surayya-MSsurayya-MS mentioned this pull request Apr 4, 2023
Closed
buyaa-n
buyaa-n reviewed Apr 5, 2023
View reviewed changes
Comment threadsrc/libraries/System.Runtime/ref/System.Runtime.cs Outdated
buyaa-n
buyaa-n approved these changes Apr 5, 2023
View reviewed changes

@buyaa-nbuyaa-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@stephentoub

stephentoub commented Apr 5, 2023

Copy link
Copy Markdown
MemberAuthor

Thanks.

@stephentoub
stephentoub merged commit aca3fcc into dotnet:mainApr 6, 2023
@stephentoub
stephentoub deleted the aoorethrowequal branch April 6, 2023 02:33
@build-analysisbuild-analysisBot mentioned this pull request Apr 6, 2023
Open
@xtqqczze

xtqqczze commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

@stephentoub I've proposed ArgumentOutOfRangeException.ThrowIfNotZero (#84415).

@ghostghost locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
+2 more reviewers
@xtqqczzextqqczzextqqczze left review comments
@buyaa-nbuyaa-nbuyaa-n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoubstephentoub

Labels

new-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: ArgumentOutOfRangeException.ThrowIfEqual and ThrowIfNotEqual

4 participants

@stephentoub@xtqqczze@jeffhandley@buyaa-n