[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965

Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged

[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom
simonrozsival:backport/pr-67589-to-release/6.0

Conversation

@simonrozsival

@simonrozsivalsimonrozsival commented Mar 27, 2023

Copy link
Copy Markdown
Member

Backport of #67589 to release/6.0

/cc @am11@adamsitnik

Customer impact

A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.

This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.

Fixes#83816

Testing

Manual testing and unit tests.

Risk

Low. The fix is well tested.

dotnet-maestroBotand others added 3 commits March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival added Servicing-consider Issue for next servicing release review area-System.Diagnostics.Process labels Mar 27, 2023
@simonrozsivalsimonrozsival added this to the 6.0.x milestone Mar 27, 2023
@ghost

ghost commented Mar 27, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #67589 to release/6.0

/cc @am11@adamsitnik

Customer impact

A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.

This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.

Fixes #83816

Testing

Manual testing and unit tests.

Risk

Low. The fix is well tested.

Author:simonrozsival
Assignees:-
Labels:

Servicing-consider, area-System.Diagnostics.Process

Milestone:6.0.x

@build-analysisbuild-analysisBot mentioned this pull request Mar 27, 2023
Closed
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 28, 2023
@rbhandarbhanda modified the milestones: 6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival changed the base branch from release/6.0 to release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival changed the base branch from release/6.0-staging to release/6.0March 28, 2023 20:02
@carlossanlop

carlossanlop commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.

Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:

  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.

The new process is described here: runtime/docs/project/library-servicing.md.

The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.

Let me know if you have any questions.

@carlossanlop
carlossanlop changed the base branch from release/6.0 to release/6.0-stagingMarch 28, 2023 21:07
This was referenced Mar 29, 2023
Closed
Closed
Closed
Closed
Closed
@simonrozsival

simonrozsival commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks, @carlossanlop.

@simonrozsival
simonrozsival marked this pull request as draft March 29, 2023 12:52
@simonrozsival

simonrozsival commented Mar 29, 2023

Copy link
Copy Markdown
MemberAuthor

@runfoapprunfoappBot mentioned this pull request Mar 29, 2023
Closed
@simonrozsival
simonrozsival marked this pull request as ready for review March 30, 2023 07:38
@carlossanlop

carlossanlop commented Mar 30, 2023•
edited by simonrozsival
Loading

Copy link
Copy Markdown
Contributor

@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:

  • Sign-off by area owner.
  • No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  • Approved by Tactics. Mandatory Servicing-approved label applied.
  • CI is green.

The Code-complete date for the May 2023 Release is April 10th.

adamsitnik
adamsitnik approved these changes Mar 31, 2023
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !

@simonrozsival
simonrozsival merged commit cfa7b27 into dotnet:release/6.0-stagingMar 31, 2023
@ghostghost locked as resolved and limited conversation to collaborators Apr 30, 2023
@leecowleecow modified the milestones: 6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) - #83965
Merged
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Mar 31, 2023
Merged
[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589)#83965
simonrozsival merged 6 commits into
dotnet:release/6.0-stagingfrom 
simonrozsival:backport/pr-67589-to-release/6.0
Conversation
@simonrozsival
@simonrozsivalsimonrozsival
commented
Mar 27, 2023

Copy link


Copy Markdown

Member
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes#83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
dotnet-maestroBotand others
added 3 commits
March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
f2db6d6
…23.2 (dotnet#83857)
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.400
From Version 6.0.15 -> To Version 6.0.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@am11@adamsitnik
@jeffhandley@simonrozsival
Use CLOCK_BOOTTIME to calculate BootTime on linux (dotnet#67589)
f45eca8
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Simon Rozsival <simon@rozsival.com>
@simonrozsival
Replace LibraryImport with DllImport in .NET 6.0
cca5076
@simonrozsivalsimonrozsival
added

Servicing-consider
Issue for next servicing release review
area-System.Diagnostics.Process

labels
Mar 27, 2023
@simonrozsivalsimonrozsival
added this to the 6.0.x milestone
Mar 27, 2023
@ghost
ghost
commented
Mar 27, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-diagnostics-process

See info in area-owners.md if you want to be subscribed.
Issue Details
Backport of #67589 to release/6.0
/cc @am11@adamsitnik
Customer impact
A customer reported that they can't use the Process.StartTime API in their Android app (#83816). The problem is that recent Android versions don't allow reading the /proc/stat file anymore. Instead, we use the clock_gettime libc function.
This bug as already been fixed in .NET 8 but we didn't backport it to .NET 6.0 at that time. The .NET 6.0 MAUI support lasts until the end of May 2023 so we should backport this bugfix.
Fixes #83816
Testing
Manual testing and unit tests.
Risk
Low. The fix is well tested.
Author:simonrozsival
Assignees:-
Labels:
Servicing-consider, area-System.Diagnostics.Process
Milestone:6.0.x
@build-analysisbuild-analysisBot
mentioned this pull request
Mar 27, 2023

Closed

@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Mar 28, 2023
@rbhandarbhanda
modified the milestones:
6.0.x, 6.0.16, 6.0.17Mar 28, 2023
@simonrozsival
simonrozsival
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 20:02
@simonrozsival
simonrozsival
changed the base branch from
release/6.0-staging
to
release/6.0March 28, 2023 20:02
@carlossanlop
carlossanlop
commented
Mar 28, 2023

Copy link


Copy Markdown

Contributor
I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.
Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.
The new process is described here: runtime/docs/project/library-servicing.md.
The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.
Let me know if you have any questions.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0
to
release/6.0-stagingMarch 28, 2023 21:07

This was referenced Mar 29, 2023

Closed


Closed


Closed


Closed


Closed

@simonrozsival
simonrozsival
commented
Mar 29, 2023•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks, @carlossanlop.
@simonrozsival
simonrozsival
marked this pull request as draft
March 29, 2023 12:52
@simonrozsival
simonrozsival
commented
Mar 29, 2023

Copy link


Copy Markdown

MemberAuthor
@runfoapprunfoappBot
mentioned this pull request
Mar 29, 2023

Closed

@simonrozsival
simonrozsival
marked this pull request as ready for review
March 30, 2023 07:38
@carlossanlop
carlossanlop
commented
Mar 30, 2023•

edited by simonrozsival

Loading

Copy link


Copy Markdown

Contributor
@simonrozsival you are free to merge into the staging branches anytime, as soon as you meet the requirements:
  •  Sign-off by area owner.
  •  No OOB changes needed for the involved assemblies. System.Diagnostics.Process does not have IsPackable set to true.
  •  Approved by Tactics. Mandatory Servicing-approved label applied.
  •  CI is green.
The Code-complete date for the May 2023 Release is April 10th.
adamsitnik
adamsitnik
approved these changes
Mar 31, 2023
View reviewed changes
@adamsitnikadamsitnik
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @simonrozsival !
@simonrozsival
simonrozsival
merged commit cfa7b27
into
dotnet:release/6.0-stagingMar 31, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Apr 30, 2023
@leecowleecow
modified the milestones:
6.0.17, 6.0.18Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.Diagnostics.ProcessServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

6 participants

@simonrozsival@carlossanlop@adamsitnik@leecow@rbhanda@am11