Skip to content

[browser][non-icu] HybridGlobalization change case - #84019

Merged
ilonatommy merged 25 commits into
dotnet:mainfrom
ilonatommy:hg-change-case
Apr 4, 2023
Merged

[browser][non-icu] HybridGlobalization change case#84019
ilonatommy merged 25 commits into
dotnet:mainfrom
ilonatommy:hg-change-case

Conversation

@ilonatommy

@ilonatommyilonatommy commented Mar 28, 2023

Copy link
Copy Markdown
Member

Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.

Old, icu-based private API: GlobalizationNative_ChangeCase

New, non-icu private API: ChangeCaseInvariantJS, ChangeCaseJS.

Affected public API (see: tests in TextInfoTests.cs):

  • TextInfo.ToLower - no changes in behavior,
  • TextInfo.ToUpper - no changes in behavior,
  • TextInfo.ToTitleCase - no changes in behavior.

@ilonatommyilonatommy self-assigned this Mar 28, 2023
@ghost

ghost commented Mar 28, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.

Old, icu-based private API: GlobalizationNative_ChangeCase

New, non-icu private API: ChangeCaseInvariantJS, ChangeCaseJS.

Affected public API (see: tests in TextInfoTests.cs):

  • TextInfo.ToLower - no changes in behavior,
  • TextInfo.ToUpper - no changes in behavior,
  • TextInfo.ToTitleCase - no changes in behavior.
Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-System.Globalization

Milestone:-

@ilonatommy
ilonatommy marked this pull request as draft March 28, 2023 13:55
@runfoapprunfoappBot mentioned this pull request Mar 28, 2023
Closed
This was referenced Mar 28, 2023
Open
Closed
@build-analysisbuild-analysisBot mentioned this pull request Mar 28, 2023
Closed
@ilonatommy
ilonatommy marked this pull request as ready for review March 30, 2023 13:47
This was referenced Mar 30, 2023
Closed
Closed
Closed
mkhamoyan
mkhamoyan reviewed Mar 31, 2023
View reviewed changes
Comment threadsrc/libraries/System.Globalization/System.Globalization.sln
mkhamoyan
mkhamoyan reviewed Mar 31, 2023
View reviewed changes
Comment threadsrc/libraries/System.Globalization/System.Globalization.sln Outdated
mkhamoyan
mkhamoyan reviewed Mar 31, 2023
View reviewed changes
Comment threadsrc/libraries/System.Globalization/System.Globalization.sln
mkhamoyan
mkhamoyan reviewed Mar 31, 2023
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.targets
This was referenced Mar 31, 2023
Open
Closed
@ilonatommyilonatommy mentioned this pull request Apr 3, 2023
Merged
kg
kg reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/corebindings.c
kg
kg reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/icu.ts
kg
kg reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/net6-legacy/method-calls.ts Outdated
kg
kg reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/net6-legacy/method-calls.ts
kg
kg reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/net6-legacy/method-calls.ts
kg
kg approved these changes Apr 3, 2023
View reviewed changes

@kgkg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from comments

@ilonatommy

ilonatommy commented Apr 4, 2023

Copy link
Copy Markdown
MemberAuthor

I am merging but if there are any new ideas later, feel free to let me know and we will solve them in a follow-up, cc @pavelsavara, @radical.

@ilonatommy
ilonatommy merged commit 9afb7d4 into dotnet:mainApr 4, 2023
pavelsavara
pavelsavara reviewed Apr 11, 2023
View reviewed changes
Comment threaddocs/design/features/hybrid-globalization.md

### WASM

For WebAssembly, both on Browser and WASI, we are using Web API instead of some ICU data.

@pavelsavarapavelsavaraApr 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Web API in WASI. It probably means that the whole Hybrid Globalization can't be implemented there.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs
{
internal static bool Invariant { get; } = AppContextConfigHelper.GetBooleanConfig("System.Globalization.Invariant", "DOTNET_SYSTEM_GLOBALIZATION_INVARIANT");
#if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS
#if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS || TARGET_BROWSER || TARGET_WASI

@pavelsavarapavelsavaraApr 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no WASI ?

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/GlobalizationMode.cs
// static cctor (on Unix) to be preserved when Invariant=false.
internal static bool Invariant => Settings.Invariant;
#if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS
#if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS || TARGET_BROWSER || TARGET_WASI

@pavelsavarapavelsavaraApr 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no WASI ?

This was referenced Apr 11, 2023
Merged
Closed
@ghostghost locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@radicalradicalAwaiting requested review from radical
@lewinglewingAwaiting requested review from lewinglewing is a code owner
+2 more reviewers
@kgkgkg approved these changes
@mkhamoyanmkhamoyanmkhamoyan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-System.Globalization

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ilonatommy@kg@pavelsavara@mkhamoyan@tarekgh