') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Remove HybridGlobalization info from linker feature switches by mkhamoyan · Pull Request #84073 · dotnet/runtime · GitHub
Skip to content

Remove HybridGlobalization info from linker feature switches - #84073

Merged
akoeplinger merged 1 commit into
mainfrom
update_doc_info
Mar 29, 2023
Merged

Remove HybridGlobalization info from linker feature switches#84073
akoeplinger merged 1 commit into
mainfrom
update_doc_info

Conversation

@mkhamoyan

@mkhamoyanmkhamoyan commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

As discussed in #81470 (comment) , feature switches listed in feature-switches.md are linker feature switches.
HybridGlobalization is a regular AppContext switch and shouldn't be here.

@ghostghost added the area-Meta label Mar 29, 2023
@ghostghost assigned mkhamoyanMar 29, 2023
@ghost

ghost commented Mar 29, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

As discusses in #81470 (comment) , feature switches listed in feature-switches.md are linker feature switches.
HybridGlobalization is a regular AppContext switch and shouldn't be here.

Author:mkhamoyan
Assignees:mkhamoyan
Labels:

area-Meta

Milestone:-

@ghost

ghost commented Mar 29, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

As discusses in #81470 (comment) , feature switches listed in feature-switches.md are linker feature switches.
HybridGlobalization is a regular AppContext switch and shouldn't be here.

Author:mkhamoyan
Assignees:mkhamoyan
Labels:

area-Meta, area-System.Globalization

Milestone:-

@mkhamoyanmkhamoyan added the os-ios Apple iOS label Mar 29, 2023
ilonatommy
ilonatommy reviewed Mar 29, 2023
View reviewed changes

@ilonatommyilonatommy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @akoeplinger features listed here are only linker features. I do not agree that PredefinedCulturesOnly is a linker feature, to my understanding it does not result in trimming code but in throwing an exception. Should we remove it as well?

@akoeplinger

akoeplinger commented Mar 29, 2023

Copy link
Copy Markdown
Member

PredefinedCulturesOnly is a linker feature switch since it has a substitution in

runtime/src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.Shared.xml

Line 13 in e14174b

<methodsignature="System.Boolean get_PredefinedCulturesOnly()"body="stub"value="true"feature="System.Globalization.PredefinedCulturesOnly"featurevalue="true" />

That means when the switch is turned on the substitution happens and the binary gets trimmed differently.

@akoeplinger
akoeplinger merged commit 7e8f438 into mainMar 29, 2023
@akoeplinger
akoeplinger deleted the update_doc_info branch March 29, 2023 13:50
@ghostghost locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@steveisoksteveisoksteveisok approved these changes
@mdh1418mdh1418Awaiting requested review from mdh1418
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@mkhamoyanmkhamoyan

Labels

area-Metaarea-System.Globalizationos-iosApple iOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkhamoyan@akoeplinger@steveisok@ilonatommy