Uh oh!
There was an error while loading. Please reload this page.
[wasm] Simd refactoring - #84170
Merged
Merged
Conversation
Rename few opcodes to contain `_SIMD_`. Use more SimdIntrinsic fields to simplify the code.
radekdoulik
requested review from
SamMonoRT, lambdageek and vargaz
as code ownersMarch 31, 2023 15:02
vargaz
approved these changes
Mar 31, 2023
vargaz
reviewed
Mar 31, 2023
Uh oh!
There was an error while loading. Please reload this page.
kg
reviewed
Apr 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
kg
reviewed
Apr 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
kg
reviewed
Apr 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
kg
approved these changes
Apr 4, 2023
Because `emit_hardware_intrinsics` doesn't call custom emit in such case and so we endup with code emitted with wrong zero c0.
This was referenced Apr 4, 2023
radekdoulik
commented
Apr 5, 2023
MemberAuthor
The failing builds are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename few opcodes to contain
_SIMD_.Use more SimdIntrinsic fields to simplify the code.