Delete gtGetStructHandle and friends - #84212

Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged

Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom
SingleAccretion:No-Get-Handle-Upstream

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Apr 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.

Includes the deletion of IsSimdAsHWIntrinsic logic.

Diffs - see below for the explanation.

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 1, 2023
@ghost

ghost commented Apr 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.

Includes the deletion of IsSimdAsHWIntrinsic logic.

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

SingleAccretion
SingleAccretion commented Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp
Comment on lines +1657 to +1658
structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);

@SingleAccretionSingleAccretionApr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.

The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.

@SingleAccretion
SingleAccretion marked this pull request as ready for review April 1, 2023 20:19
@SingleAccretion

SingleAccretion commented Apr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

tannergooding
tannergooding reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h
Comment on lines 8388 to 8393
CORINFO_CLASS_HANDLE PlaneHandle;
CORINFO_CLASS_HANDLE QuaternionHandle;
CORINFO_CLASS_HANDLE Vector2Handle;
CORINFO_CLASS_HANDLE Vector3Handle;
CORINFO_CLASS_HANDLE Vector4Handle;
CORINFO_CLASS_HANDLE VectorHandle;

@tannergoodingtannergoodingApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?

@tannergoodingtannergoodingApr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?

@SingleAccretionSingleAccretionApr 3, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?

Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).

@AndyAyersMS

AndyAyersMS commented Apr 6, 2023

Copy link
Copy Markdown
Member

@SingleAccretion can you fix up the merge conflicts?

@SingleAccretion

SingleAccretion commented Apr 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Conflicts have been fixed.

@AndyAyersMS

AndyAyersMS commented Apr 10, 2023

Copy link
Copy Markdown
Member

Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.

I thkink the SPMI failures are also known issues -- @kunalspathak FYI

[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding

tannergooding commented Apr 10, 2023

Copy link
Copy Markdown
Member

#84536 Is the Arm64 SPMI failure

@AndyAyersMS

AndyAyersMS commented Apr 10, 2023

Copy link
Copy Markdown
Member

#84536 Is the Arm64 SPMI failure

Thanks. Going to merge this.

@AndyAyersMS
AndyAyersMS merged commit a7f3df9 into dotnet:mainApr 10, 2023
@AndyAyersMS

AndyAyersMS commented Apr 10, 2023

Copy link
Copy Markdown
Member

@SingleAccretion thank you.

@tannergoodingtannergooding mentioned this pull request Apr 10, 2023
Merged
@EgorBoEgorBo mentioned this pull request Apr 11, 2023
Merged
@EgorBoEgorBo mentioned this pull request Apr 11, 2023
Merged
@SingleAccretion
SingleAccretion deleted the No-Get-Handle-Upstream branch April 11, 2023 16:22
@ghostghost locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Delete gtGetStructHandle and friends - #84212
Merged
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Apr 10, 2023
Merged
Delete gtGetStructHandle and friends#84212
AndyAyersMS merged 11 commits into
dotnet:mainfrom 
SingleAccretion:No-Get-Handle-Upstream
Conversation
@SingleAccretion
@SingleAccretionSingleAccretion
commented
Apr 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
All of this infrastructure has been made obsolete by the recent changes to support block-typed and SIMD locals without handles.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Diffs - see below for the explanation.
@ghostghost
added

community-contribution
Indicates that the PR has been added by a community member
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
labels
Apr 1, 2023
@ghost
ghost
commented
Apr 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
All of this infrastructure has been made obsolete by the recent changes to support block-typed locals.
Includes the deletion of IsSimdAsHWIntrinsic logic.
Author:SingleAccretion
Assignees:-
Labels:
area-CodeGen-coreclr, community-contribution
Milestone:-
SingleAccretion
SingleAccretion
commented
Apr 1, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/fginline.cpp

Comment on lines

+1657
 to 
+1658

 structHnd = lclVarInfo[argNum].lclVerTypeInfo.GetClassHandleForValueClass();
assert(structHnd != NO_CLASS_HANDLE);
@SingleAccretionSingleAccretionApr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the few diffs: previously, the struct handle could be "refined" to a type more specific than f(__Canon), which affects VN-based copy propagation.
The diffs could be fixed (i. e. made to not exist), but only with quirks, which I did not find worth it due to the already-not-small size of this change.
@SingleAccretion
SingleAccretion
marked this pull request as ready for review
April 1, 2023 20:19
@SingleAccretion
SingleAccretion
commented
Apr 1, 2023

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib
tannergooding
tannergooding
reviewed
Apr 3, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h

Comment on lines

8388
 to 
8393

 CORINFO_CLASS_HANDLE PlaneHandle;
 CORINFO_CLASS_HANDLE QuaternionHandle;
 CORINFO_CLASS_HANDLE Vector2Handle;
 CORINFO_CLASS_HANDLE Vector3Handle;
 CORINFO_CLASS_HANDLE Vector4Handle;
 CORINFO_CLASS_HANDLE VectorHandle;
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these ones need to stay?
@tannergoodingtannergoodingApr 3, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType? Is there a plan to also remove that somehow?
@SingleAccretionSingleAccretionApr 3, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for isOpaqueSIMDType?
Yep. No explicit plans for its removal currently, though one could certainly imagine rewriting it to not need the cached handles (e. g. a new getClassAttribs flag, or matching by name).
@AndyAyersMS
AndyAyersMS
commented
Apr 6, 2023

Copy link


Copy Markdown

Member
@SingleAccretion can you fix up the merge conflicts?
@SingleAccretion
SingleAccretion
commented
Apr 6, 2023

Copy link


Copy Markdown

ContributorAuthor
Conflicts have been fixed.
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
Linux arm64 failure looks like an instance of #82771 or similar, hard to be sure without artifacts.
I thkink the SPMI failures are also known issues -- @kunalspathak FYI
[20:35:14] ISSUE: <ASSERT> #463912 D:\a\_work\1\s\src\coreclr\jit\lsra.cpp (11880) - Assertion failed '!"Spill candidate has no assignedInterval recentRefPosition"' in 'JIT.HardwareIntrinsics.Arm._AdvSimd.VectorLookup_3Test__VectorTableLookupSByte:RunBasicScenario_UnsafeRead():this' during 'LSRA build intervals' (IL size 169; hash 0xe0ad7041; FullOpts)

@tannergooding
tannergooding
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
#84536 Is the Arm64 SPMI failure
Thanks. Going to merge this.
@AndyAyersMS
AndyAyersMS
merged commit a7f3df9
into
dotnet:mainApr 10, 2023
@AndyAyersMS
AndyAyersMS
commented
Apr 10, 2023

Copy link


Copy Markdown

Member
@SingleAccretion thank you.
@tannergoodingtannergooding
mentioned this pull request
Apr 10, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@EgorBoEgorBo
mentioned this pull request
Apr 11, 2023
 Merged

@SingleAccretion
SingleAccretion
deleted the

No-Get-Handle-Upstream

branch
April 11, 2023 16:22
@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees


No one assigned


Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@SingleAccretion@AndyAyersMS@tannergooding