Skip to content

Introducing Time abstraction Part2 (down-level support) - #84235

Merged
tarekgh merged 5 commits into
dotnet:mainfrom
tarekgh:TimeAbstraction-Part2
Apr 7, 2023
Merged

Introducing Time abstraction Part2 (down-level support)#84235
tarekgh merged 5 commits into
dotnet:mainfrom
tarekgh:TimeAbstraction-Part2

Conversation

@tarekgh

@tarekghtarekgh commented Apr 3, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This change is adding the time abstraction to the down-levels.

#83604
#36617

@ghostghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Apr 3, 2023
@ghostghost assigned tarekghApr 3, 2023
@ghost

ghost commented Apr 3, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@tarekgh
tarekgh requested a review from stephentoubApril 3, 2023 00:50
@tarekghtarekgh added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 3, 2023
@ghost

ghost commented Apr 3, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details

This change is adding the time abstraction to the down-levels.

#83604

Author:tarekgh
Assignees:tarekgh
Labels:

new-api-needs-documentation, area-System.DateTime

Milestone:-

@tarekghtarekgh added this to the 8.0.0 milestone Apr 3, 2023
@tarekgh

tarekgh commented Apr 3, 2023

Copy link
Copy Markdown
MemberAuthor

@ericstj Could you please have a look at the newly introduced library and confirm I got the building and packaging, correct?

CC @terrajobst

stephentoub
stephentoub reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/TimeProvider.cs Outdated
This was referenced Apr 3, 2023
Closed
Closed
ericstj
ericstj reviewed Apr 3, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj Outdated
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/ref/Microsoft.Bcl.TimeProvider.Forwards.cs
huoyaoyuan
huoyaoyuan reviewed Apr 4, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/TimeProvider.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Apr 4, 2023
Closed
ericstj
ericstj approved these changes Apr 4, 2023
View reviewed changes

@ericstjericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOB project looks correct.

Comment thread...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
@build-analysisbuild-analysisBot mentioned this pull request Apr 5, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request Apr 6, 2023
Open
stephentoub
stephentoub reviewed Apr 6, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/TimeProvider.cs
stephentoub
stephentoub reviewed Apr 6, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/TimeProvider.cs
gewarren
gewarren reviewed Apr 6, 2023
View reviewed changes
Comment thread...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs Outdated
Comment thread...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs Outdated
@tarekgh
tarekgh merged commit 84065a8 into dotnet:mainApr 7, 2023
This was referenced Apr 7, 2023
Closed
Merged
ViktorHofer
ViktorHofer reviewed May 2, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj

<ItemGroup Condition="'$(IsPartialFacadeAssembly)' != 'true'">
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="$(MicrosoftBclAsyncInterfacesVersion)" />
<PackageReference Include="System.ValueTuple" Version="$(SystemValueTupleVersion)" />

@ViktorHoferViktorHoferMay 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netstandard2.0 shouldn't reference this library as it's already provided inbox.

@ViktorHoferViktorHoferMay 2, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#85639

@ghostghost locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqkrwq left review comments
@ViktorHoferViktorHoferViktorHofer left review comments
@ericstjericstjericstj approved these changes
@gewarrengewarrengewarren left review comments
@stephentoubstephentoubstephentoub approved these changes
+3 more reviewers
@carlossanlopcarlossanlopcarlossanlop left review comments
@huoyaoyuanhuoyaoyuanhuoyaoyuan left review comments
@danmoseleydanmoseleydanmoseley left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tarekghtarekgh

Labels

area-System.DateTimenew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@tarekgh@krwq@carlossanlop@stephentoub@huoyaoyuan@danmoseley@ViktorHofer@ericstj@gewarren