Tar: Improve unseekable stream handling by carlossanlop · Pull Request #84279 · dotnet/runtime

carlossanlop · 2023-04-04T02:51:49Z

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop · 2023-04-04T02:51:49Z

Fixes#76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A new path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

ghost · 2023-04-04T02:52:16Z

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76690

Addresses the issue reported in dotnet/sdk-container-builds#192 (comment) by @rainersigwald

Before this change, it wasn't possible to write into an archive a file entry that contained an unseekable data stream. The undelying cause was that we were calling Length to try to get the total number of bytes of the data stream, but it is unsupported when the stream's CanSeek is false.

The way I fixed this was by separating the code that writes an entry into two possible paths:

One path for entries with seekable data streams, which remains mostly unmodified.
A newnew path for entries with unseekable streams, which changes the order in which we collect the entry information into the buffer:
- First, write into the buffer all the metadata except for the size field.
- Then, write the data stream into the archive (this is possible because we know the exact location where the data should start), counting the number of bytes that are written.
- Afterwards, write that collected length value in the location for the size field in the buffer.
- Finally, calculate the checksum, then write the buffer into the archive.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	`area-System.Formats.Tar`
Milestone:	-

carlossanlop · 2023-04-04T15:30:24Z

I'll remove the new file TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs and will submit it in a separate PR. It isn't related to this change.
Edit: Merged in separate PR: #84303

adamsitnik

Overall it LGTM, but it would be nice if we could reduce the code duplication before merging.

Thank you @carlossanlop !

Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

… stream into an unseekable archive stream.

…in a separate PR.

… Add extra debug asserts.

adamsitnik

LGTM, please apply my suggestions before merging.

carlossanlop · 2023-06-01T03:35:44Z

Failures are unrelated.

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

carlossanlop requested review from ViktorHofer, ericstj, jeffhandley, jozkee and rainersigwald April 4, 2023 02:51

carlossanlop self-assigned this Apr 4, 2023

ghost added the area-System.Formats.Tar label Apr 4, 2023

build-analysisBot mentioned this pull request Apr 4, 2023
WasmTestOnBrowser-System.* test failures in CI #83655
Closed

carlossanlop mentioned this pull request Apr 4, 2023
Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84303
Merged

carlossanlop requested review from adamsitnik and stephentoub April 4, 2023 16:17

build-analysisBot mentioned this pull request Apr 4, 2023
CI System.Text.RegularExpressions.Tests failure #84323
Closed

carlossanlop mentioned this pull request Apr 25, 2023
Add async ZipFile APIs #1541
Closed
15 tasks

adamsitnik reviewed May 17, 2023
View reviewed changes

adamsitnik added this to the 8.0.0 milestone May 17, 2023

carlossanlop added 13 commits May 22, 2023 19:17

Add tests that verify we handle unseekable streams correctly.
295613c
Adjust existing unseekable stream tests to verify correct for all formats and with multiple tar entries.

Add expected data field locations for all supported formats.
d627497

Add exception message for when attempting to write an unseekable data…
018f709
… stream into an unseekable archive stream.

Add seekability validation in public TarWriter entry writing methods.
9092cb4

Add TarFile stream roundtrip tests for unseekable streams.
6c460eb

Add missing async TarFile roundtrip tests.
6ea8e0f

Support unseekable streams in TarHeader.Write.
f87b9e9

Reuse and simplify the code.
e94fefb

More reuse, remove unused and not needed.
15523ac

Remove TarFile.CreateFromDirectoryAsync.File.Roundtrip.cs. Submit it …
5979be9
…in a separate PR.

Remove unnecessary resx comments.
b702a44

Dedicated method for writing fields to buffer depending on the format.
625a619

Specify Data in name of method that expects unseekable data stream.…
4f702c4
… Add extra debug asserts.

carlossanlop added 4 commits May 23, 2023 15:22

Delete unnecessary method.
0054f99

Rename WritePadding to WriteEmptyPadding
2fc23de

Rename test variables
d81b5a8

Merge identical test arrays into one
796d542

carlossanlop requested a review from adamsitnik May 24, 2023 03:27

adamsitnik approved these changes May 24, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated
Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

carlossanlop added 4 commits May 24, 2023 13:01

Invert if else to be more clear about conditions
94157b0

remove size assign comment
1557885

Remove redundant debug assert
943988b

Async padding byte array creation simplification
abff5c0

adamsitnik reviewed May 25, 2023
View reviewed changes

Comment threadsrc/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs Outdated

Apply suggestions from code review
66dc094

build-analysisBot mentioned this pull request May 25, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed

carlossanlop merged commit 84a7be7 into dotnet:mainJun 1, 2023

carlossanlop deleted the TarUnseekableDataStream branch June 1, 2023 03:35

carlossanlop mentioned this pull request Jun 30, 2023
Tar: Fix PAX regression when handling the size of really long unseekable data streams #88280
Merged

ghost locked as resolved and limited conversation to collaborators Jul 1, 2023

Uh oh!

Conversation

carlossanlop commented Apr 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 4, 2023

Uh oh!

carlossanlop commented Apr 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlossanlop commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

carlossanlop commented Apr 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Apr 4, 2023

Uh oh!

carlossanlop commented Apr 4, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlossanlop commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading

carlossanlop commented Apr 4, 2023•
edited
Loading