Skip to content

Move COM source generator APIs to System.Runtime.InteropServices.dll - #84329

Merged
jkoritzinsky merged 4 commits into
dotnet:mainfrom
jkoritzinsky:public-com-generator
Apr 13, 2023
Merged

Move COM source generator APIs to System.Runtime.InteropServices.dll#84329
jkoritzinsky merged 4 commits into
dotnet:mainfrom
jkoritzinsky:public-com-generator

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Apr 4, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This makes the COM source generator part of the shipping product.

This should wait to go in until #84271 goes in to ensure they both are in for the first release.

Fixes#79121, Fixes#83471

@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Apr 4, 2023
@jkoritzinskyjkoritzinsky added this to the 8.0.0 milestone Apr 4, 2023
@ghost

ghost commented Apr 4, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Apr 4, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes the COM source generator part of the shipping product.

This should wait to go in until #84271 goes in to ensure they both are in for the first release.

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:8.0.0

This was referenced Apr 5, 2023
Closed
Closed
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Apr 11, 2023
View reviewed changes
Comment threadsrc/libraries/System.Runtime.InteropServices/System.Runtime.InteropServices.sln
Comment threadsrc/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Comment threadsrc/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Comment thread....InteropServices/src/System/Runtime/InteropServices/Marshalling/ExceptionAsVoidMarshaller.cs
Comment thread...ime.InteropServices/src/System/Runtime/InteropServices/Marshalling/IIUnknownCacheStrategy.cs
@build-analysisbuild-analysisBot mentioned this pull request Apr 12, 2023
Closed
@jkoritzinsky
jkoritzinsky merged commit b9df364 into dotnet:mainApr 13, 2023
@jkoritzinsky
jkoritzinsky deleted the public-com-generator branch April 13, 2023 22:13
@ghostghost locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@jtschusterjtschusterAwaiting requested review from jtschuster
@elinor-fungelinor-fungAwaiting requested review from elinor-fung

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicesnew-api-needs-documentationsource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: APIs to expose managed objects to COM [API Proposal]: COM source generator APIs

2 participants

@jkoritzinsky@AaronRobinsonMSFT