Uh oh!
There was an error while loading. Please reload this page.
JIT: Set GTF_DEBUG_NODE_MORPHED properly in block morph - #84352
Merged
Conversation
With side effects that may go on top, it may be block morph's responsibility to set this flag. Also set the type of the reused GT_COMMA nodes; haven't actually seen any issues here, but seems prudent to do this. Fixes some stress issues seen over in dotnet#83771.
ghost
commented
Apr 5, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsWith side effects that may go on top, it may be block morph's responsibility to set this flag. Also set the type of the reused GT_COMMA nodes; haven't actually seen any issues here, but seems prudent to do this. Fixes some stress issues seen over in #83771.
|
jakobbotsch
commented
Apr 5, 2023
MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Apr 6, 2023
This was referenced Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With side effects that may go on top, it may be block morph's responsibility to set this flag.
Also set the type of the reused GT_COMMA nodes; haven't actually seen any issues here, but seems prudent to do this.
Fixes some stress issues seen over in #83771.