Skip to content

Add AggressiveInlining to Char.IsLatin1 - #84414

Closed
xtqqczze wants to merge 1 commit into
dotnet:mainfrom
xtqqczze:patch-4
Closed

Add AggressiveInlining to Char.IsLatin1#84414
xtqqczze wants to merge 1 commit into
dotnet:mainfrom
xtqqczze:patch-4

Conversation

@xtqqczze

@xtqqczzextqqczze commented Apr 6, 2023

Copy link
Copy Markdown
Contributor
  • Force the JIT to inline this 17 byte method to elide bounds checks.
  • Remove useless uint casts as char is unsigned and ReadOnlySpan<T>.Length is never negative.

@xtqqczze
Add AggressiveInlining to Char.IsLatin1
2668b39
* Force the JIT to inline this 17 byte method to elide bounds checks.
* Remove useless `uint` casts as `char` is unsigned and `ReadOnlySpan<T>.Length` is never negative.
@ghostghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners community-contribution Indicates that the PR has been added by a community member labels Apr 6, 2023
EgorBo
EgorBo reviewed Apr 6, 2023
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Char.cs
@stephentoubstephentoub added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 6, 2023
@xtqqczze
xtqqczze deleted the patch-4 branch April 6, 2023 13:27
This was referenced Apr 6, 2023
Open
Closed
@ghostghost locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo left review comments
@stephentoubstephentoubstephentoub left review comments

Assignees

No one assigned

Labels

community-contributionIndicates that the PR has been added by a community memberneeds-area-labelAn area label is needed to ensure this gets routed to the appropriate area ownersNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze@EgorBo@stephentoub