Skip to content

[OSX] HybridGlobalization implement locale native functions - #84417

Merged
mkhamoyan merged 18 commits into
mainfrom
hybrid_local_functions
Apr 16, 2023
Merged

[OSX] HybridGlobalization implement locale native functions#84417
mkhamoyan merged 18 commits into
mainfrom
hybrid_local_functions

Conversation

@mkhamoyan

@mkhamoyanmkhamoyan commented Apr 6, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Implemented following native functions for OSX platforms

  • GlobalizationNative_GetLocaleInfoIntNative,
  • GlobalizationNative_GetLocaleInfoPrimaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleInfoSecondaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleTimeFormatNative

Contributes to #80689
cc @SamMonoRT

@ghostghost assigned mkhamoyanApr 6, 2023
@ghost

ghost commented Apr 6, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implemented following native functions for OSX platforms

  • GlobalizationNative_GetLocaleInfoIntNative,
  • GlobalizationNative_GetLocaleInfoPrimaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleInfoSecondaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleTimeFormatNative

Contributes to #80689

Author:mkhamoyan
Assignees:mkhamoyan
Labels:

area-System.Globalization

Milestone:-

@mkhamoyanmkhamoyan added os-ios Apple iOS os-tvos Apple tvOS labels Apr 6, 2023
@ghost

ghost commented Apr 6, 2023

Copy link
Copy Markdown

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Implemented following native functions for OSX platforms

  • GlobalizationNative_GetLocaleInfoIntNative,
  • GlobalizationNative_GetLocaleInfoPrimaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleInfoSecondaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleTimeFormatNative

Contributes to #80689

Author:mkhamoyan
Assignees:mkhamoyan
Labels:

area-System.Globalization, os-ios

Milestone:-

@mkhamoyanmkhamoyan added the os-maccatalyst MacCatalyst OS label Apr 6, 2023
@ghost

ghost commented Apr 6, 2023

Copy link
Copy Markdown

Tagging subscribers to 'os-maccatalyst': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Implemented following native functions for OSX platforms

  • GlobalizationNative_GetLocaleInfoIntNative,
  • GlobalizationNative_GetLocaleInfoPrimaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleInfoSecondaryGroupingSizeNative,
  • GlobalizationNative_GetLocaleTimeFormatNative

Contributes to #80689

Author:mkhamoyan
Assignees:mkhamoyan
Labels:

area-System.Globalization, os-ios, os-tvos, os-maccatalyst

Milestone:-

ilonatommy
ilonatommy reviewed Apr 6, 2023
View reviewed changes

@ilonatommyilonatommy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shallow review: looks good. I did not read the logic yet, I will make a 2nd round soon.

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs
This was referenced Apr 6, 2023
Open
Closed
ilonatommy
ilonatommy reviewed Apr 7, 2023
View reviewed changes

@ilonatommyilonatommy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I will approve when we finish with resolving comments.

Comment threadsrc/libraries/System.Globalization/tests/Hybrid/HybridMode.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.OSX.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Unix.cs Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m
mdh1418
mdh1418 reviewed Apr 7, 2023
View reviewed changes
Comment threadsrc/native/libs/System.Globalization.Native/pal_localeStringData.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_localeStringData.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale_internal.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_localeNumberData.h Outdated
Comment threadsrc/libraries/Common/src/Interop/Interop.Locale.OSX.cs Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m
This was referenced Apr 12, 2023
Closed
Closed
@mkhamoyan
mkhamoyan marked this pull request as ready for review April 13, 2023 13:15
mdh1418
mdh1418 reviewed Apr 13, 2023
View reviewed changes
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
@build-analysisbuild-analysisBot mentioned this pull request Apr 13, 2023
Closed
mdh1418
mdh1418 reviewed Apr 13, 2023
View reviewed changes
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale_internal.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale_internal.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_localeStringData.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_localeNumberData.h
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.h Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
Comment threadsrc/native/libs/System.Globalization.Native/pal_locale.m Outdated
@build-analysisbuild-analysisBot mentioned this pull request Apr 14, 2023
Closed
mdh1418
mdh1418 approved these changes Apr 14, 2023
View reviewed changes

@mdh1418mdh1418 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks :)

@mkhamoyan

mkhamoyan commented Apr 16, 2023

Copy link
Copy Markdown
ContributorAuthor

Failures are not related.

@mkhamoyan
mkhamoyan merged commit eafd523 into mainApr 16, 2023
@mkhamoyan
mkhamoyan deleted the hybrid_local_functions branch April 16, 2023 13:54
@mkhamoyanmkhamoyan mentioned this pull request May 2, 2023
Closed
23 tasks
@ghostghost locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mdh1418mdh1418mdh1418 approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@steveisoksteveisokAwaiting requested review from steveisok
@ilonatommyilonatommyAwaiting requested review from ilonatommy

Assignees

@mkhamoyanmkhamoyan

Labels

area-System.Globalizationos-iosApple iOSos-maccatalystMacCatalyst OSos-tvosApple tvOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkhamoyan@mdh1418@ilonatommy@tarekgh