Skip to content

[main] Update dependencies from dotnet/roslyn - #84422

Merged
lewing merged 1 commit into
mainfrom
darc-main-2da1acfd-e414-46b1-ade4-f8ad37d22fca
Apr 11, 2023
Merged

[main] Update dependencies from dotnet/roslyn#84422
lewing merged 1 commit into
mainfrom
darc-main-2da1acfd-e414-46b1-ade4-f8ad37d22fca

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
  • Build: 20230405.4
  • Date Produced: April 5, 2023 6:48:58 PM UTC
  • Commit: d7a4cad21c39e18f3d5e1f7fa7dd3f93668066b4
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslynbuild 20230…
71164ab
…405.4
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.7.0-1.23179.16 -> To Version 4.7.0-1.23205.4
@ghostghost added the area-codeflow for labeling automated codeflow label Apr 6, 2023
@build-analysisbuild-analysisBot mentioned this pull request Apr 6, 2023
Open
@lewinglewing closed this Apr 10, 2023
@lewinglewing reopened this Apr 10, 2023
@ghost

ghost commented Apr 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

  • Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
  • Build: 20230405.4
  • Date Produced: April 5, 2023 6:48:58 PM UTC
  • Commit: d7a4cad21c39e18f3d5e1f7fa7dd3f93668066b4
  • Branch: refs/heads/main
Author:dotnet-maestro[bot]
Assignees:-
Labels:

area-codeflow, area-NativeAOT-coreclr

Milestone:-

@lewing

lewing commented Apr 11, 2023

Copy link
Copy Markdown
Member

looks like an analyzer failure in the nativeaot build

@lewing

lewing commented Apr 11, 2023

Copy link
Copy Markdown
Member

cc @jaredpar

@lewing
lewing merged commit d44d93a into mainApr 11, 2023
@dotnet-maestro
dotnet-maestroBot deleted the darc-main-2da1acfd-e414-46b1-ade4-f8ad37d22fca branch April 11, 2023 12:55
@MichalStrehovskyMichalStrehovsky mentioned this pull request Apr 20, 2023
Closed
@MichalStrehovsky

MichalStrehovsky commented Apr 20, 2023

Copy link
Copy Markdown
Member

cc @jaredpar

This showed up again so I filed #85082 (this time not in NativeAOT test build, but product build). It's not clear it was caused by this PR, but it's certainly suspicious that we would see an analyzer load failure in a Roslyn update PR for the first time. I looked at the commit range but it's 220 commits in the style of "Fix comment" and "merge remote-tracking branch" so can't tell if anything looks suspect. I'm not going to go over them one by one.

@ghostghost locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflowarea-NativeAOT-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lewing@MichalStrehovsky