[NO-MERGE] 83624 jit assert instrumented with darc change by trylek · Pull Request #84450 · dotnet/runtime

trylek · 2023-04-06T21:40:14Z

This is a not-for-merge test-only change combining my tentative change disabling the JIT assertion check

Line 2614 in 983ff47

assert(!haveBlockCounts || !haveEdgeCounts);

with the PR

that originally uncovered this issue. If the CoreCLR build passes with this change, it should be safe to merge in my primary PR

#84449

without the instrumentation.

Thanks

Tomas

/cc @dotnet/jit-contrib, @dotnet/crossgen-contrib

… 20230317.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23167.1

…otnet-optimization build 20230317.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23167.4

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.3.23167.1

…17.2 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.3.23167.2

…0320.1 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.3.23162.2 -> To Version 8.0.0-preview.3.23170.1

…20.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.4.23170.1

… 20230320.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23170.2

… 20230320.3 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23170.3

…otnet-optimization build 20230320.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23170.4

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23170.4

…320.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23170.1

…20.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23163.1 -> To Version 0.11.4-alpha.23170.1

… 20230321.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23171.1

… 20230321.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23171.2

…otnet-optimization build 20230322.10 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23172.10

…22.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23172.1

…otnet-optimization build 20230323.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23173.4

…30323.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.23163.1 -> To Version 1.0.0-prerelease.23173.1

…ld 20230323.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 8.0.0-beta.23163.1 -> To Version 8.0.0-beta.23173.1

…otnet-optimization build 20230324.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23174.4

…324.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23174.1

…otnet-optimization build 20230325.4 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23166.4 -> To Version 1.0.0-prerelease.23175.4

…0327.1 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.3.23162.2 -> To Version 8.0.0-preview.4.23177.1

…27.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23177.1

…30328.2 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.23163.1 -> To Version 1.0.0-prerelease.23178.2

…28.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23178.1

…28.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23163.1 -> To Version 0.11.4-alpha.23178.1

… 20230327.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23177.2

… 20230329.1 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23165.1 -> To Version 14.0.0-alpha.1.23179.1

…ld 20230329.4 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 8.0.0-beta.23163.1 -> To Version 8.0.0-beta.23179.4

…329.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23179.1

…ild 20230329.3 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.23156.1 -> To Version 1.1.0-alpha.0.23179.3

…05.3 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23205.3

Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23203.1

The most recent aggregated runtime MIBC optimization data contains a combination of block and edge counts, possibly after a change from January 2023 that switched MIBC logic over from using block counts to edge counts. The offending assertion check wasn't expecting it and started crashing Crossgen2 during compilation of System.Private.CoreLib on Windows x64 / arm. Based on Andy Ayers' advice I'm proposing to comment out the assertion check; I have created the tracking issue dotnet#84446 to follow up on consolidation of JIT and MIBC production logic in this respect. Thanks Tomas

…026-d043b8ad94be' into 83624-JIT-assert-instrumented-with-darc-change

ghost · 2023-04-06T21:40:28Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a not-for-merge test-only change combining my tentative change disabling the JIT assertion check

runtime/src/coreclr/jit/fgprofile.cpp

Line 2614 in 983ff47

assert(!haveBlockCounts || !haveEdgeCounts);

with the PR

#83624

that originally uncovered this issue. If the CoreCLR build passes with this change, it should be safe to merge in my primary PR

#84449

without the instrumentation.

Thanks

Tomas

/cc @dotnet/jit-contrib, @dotnet/crossgen-contrib

Author:	trylek
Assignees:	trylek
Labels:	`NO-MERGE`, `area-CodeGen-coreclr`
Milestone:	-

trylek · 2023-04-06T23:34:34Z

Both builds in question (CoreCLR Windows x64 / arm) have finished successfully so I'm closing this PR to avoid wasting additional lab resources as it has served its purpose.

dotnet-maestroBotand others added 30 commits March 17, 2023 23:15

Update dependencies fromhttps://github.com/dotnet/icubuild 20230317.1
b7e1cd6
Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.3.23167.1

Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
abf18fc
…17.2 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.3.23167.2

Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
74a3e65
…20.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.3.23167.1 -> To Version 8.0.0-preview.4.23170.1

Update dependencies fromhttps://github.com/dotnet/icubuild 20230320.4
4ffc33b
Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23170.4

Update dependencies fromhttps://github.com/dotnet/msquicbuild 20230…
cfaab53
…320.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23170.1

Update dependencies fromhttps://github.com/dotnet/cecilbuild 202303…
842db39
…20.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23163.1 -> To Version 0.11.4-alpha.23170.1

Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
b181967
…22.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23172.1

Merge branch 'main' into darc-main-41d2dc4d-4dcd-43dc-9026-d043b8ad94be
8a4d2e5

Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
71b740f
…30323.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.23163.1 -> To Version 1.0.0-prerelease.23173.1

Merge branch 'main' into darc-main-41d2dc4d-4dcd-43dc-9026-d043b8ad94be
05ff42a

Update dependencies fromhttps://github.com/dotnet/msquicbuild 20230…
a28fe47
…324.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23174.1

Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
849b0a8
…27.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23177.1

Update dependencies fromhttps://github.com/dotnet/xharnessbuild 202…
1364062
…30328.2 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.23163.1 -> To Version 1.0.0-prerelease.23178.2

Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
037684c
…28.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23178.1

Update dependencies fromhttps://github.com/dotnet/cecilbuild 202303…
c9d5ad7
…28.1 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23163.1 -> To Version 0.11.4-alpha.23178.1

dotnet-maestroBotand others added 10 commits March 29, 2023 23:36

Merge branch 'main' into darc-main-41d2dc4d-4dcd-43dc-9026-d043b8ad94be
aca4d12

Update dependencies fromhttps://github.com/dotnet/msquicbuild 20230…
e84cc3f
…329.1 System.Net.MsQuic.Transport From Version 8.0.0-alpha.1.23166.1 -> To Version 8.0.0-alpha.1.23179.1

Update dependencies fromhttps://github.com/dotnet/hotreload-utilsbu…
5debec7
…ild 20230329.3 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 1.1.0-alpha.0.23156.1 -> To Version 1.1.0-alpha.0.23179.3

Rollback dotnet/msquic changes
1fdd272

Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202304…
4268ef0
…05.3 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.4.23170.1 -> To Version 8.0.0-preview.4.23205.3

Update dependencies fromhttps://github.com/dotnet/icubuild 20230403.1
bbdd8e0
Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.3.23163.3 -> To Version 8.0.0-preview.4.23203.1

Merge remote-tracking branch 'upstream/darc-main-41d2dc4d-4dcd-43dc-9…
7c4c57c
…026-d043b8ad94be' into 83624-JIT-assert-instrumented-with-darc-change

trylek added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 6, 2023

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2023

ghost assigned trylek Apr 6, 2023

trylek closed this Apr 6, 2023

build-analysisBot mentioned this pull request Apr 7, 2023
WindowsServiceLifetimeTests.ServiceCanStopItself fails in CI #84438
Closed

ghost locked as resolved and limited conversation to collaborators May 7, 2023

trylek deleted the 83624-JIT-assert-instrumented-with-darc-change branch September 5, 2023 19:28

Navigation Menu

Uh oh!

[NO-MERGE] 83624 jit assert instrumented with darc change - #84450

[NO-MERGE] 83624 jit assert instrumented with darc change#84450
trylek wants to merge 40 commits into
dotnet:mainfrom
trylek:83624-JIT-assert-instrumented-with-darc-change

trylek commented Apr 6, 2023

Uh oh!

ghost commented Apr 6, 2023

Uh oh!

trylek commented Apr 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

trylek commented Apr 6, 2023

Uh oh!

ghost commented Apr 6, 2023

Uh oh!

trylek commented Apr 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants