') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/6.0] Disable HardwareIntrinsics failing tests on Mono by kotlarmilos · Pull Request #84475 · dotnet/runtime · GitHub
Skip to content

[release/6.0] Disable HardwareIntrinsics failing tests on Mono - #84475

Merged
kotlarmilos merged 1 commit into
dotnet:release/6.0-stagingfrom
kotlarmilos:bugfix/disable-hardwareintrinsics-tests
Apr 10, 2023
Merged

[release/6.0] Disable HardwareIntrinsics failing tests on Mono#84475
kotlarmilos merged 1 commit into
dotnet:release/6.0-stagingfrom
kotlarmilos:bugfix/disable-hardwareintrinsics-tests

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented Apr 7, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes Issue #81907

Description

This PR disables the failing tests for hardware intrinsics on Mono llvmaot linux arm64. The tests report the following error message: System.Exception: One or more scenarios did not complete as expected.

Customer Impact

No customer impact, the issue is blocking clean CI.

Testing

Tested on the CI, the tests don't fail as they are disabled.

Risk

Low risk. This PR disables failing intrinsics tests. In .NET 6, Mono had just started implementing intrinsics support, so likely some Library optimizations might have exposed some limitations for Mono.

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@kotlarmiloskotlarmilos self-assigned this Apr 7, 2023
@SamMonoRTSamMonoRT added this to the 6.0.x milestone Apr 7, 2023
@SamMonoRTSamMonoRT added the Servicing-consider Issue for next servicing release review label Apr 7, 2023
@SamMonoRT

SamMonoRT commented Apr 7, 2023

Copy link
Copy Markdown
Member

/cc @steveisok

@SamMonoRT

SamMonoRT commented Apr 7, 2023

Copy link
Copy Markdown
Member

@kotlarmilos - I think this needs to be open in the staging pipeline, see more guidance from @carlossanlop in email.

@SamMonoRT

SamMonoRT commented Apr 7, 2023

Copy link
Copy Markdown
Member

@kotlarmilos - https://github.com/dotnet/runtime/blob/release/7.0-staging/docs/project/library-servicing.md

@runfoapprunfoappBot mentioned this pull request Apr 7, 2023
Closed
This was referenced Apr 7, 2023
Closed
Open
@fanyang-mono

fanyang-mono commented Apr 10, 2023

Copy link
Copy Markdown
Member

Why not backporting Zoltan's fix instead? #84385

@carlossanlop

carlossanlop commented Apr 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@kotlarmilos@SamMonoRT today is code complete. Can you please help make sure this is ready to merge by 4pm EOD today?

  • No Tactics approval needed (test change, tell-mode).
  • Please confirm the CI failures are unrelated.
  • Get a sign-off from an area owner.
  • No OOB changes needed (not affecting managed code in libraries code).

@SamMonoRT

SamMonoRT commented Apr 10, 2023

Copy link
Copy Markdown
Member

@carlossanlop - This PR seems ready for merge

Yes - the failures are not related to the changes
I'm the area owner for the aot-llvm area for Mono, I have signed off on the PR.

@SamMonoRT

SamMonoRT commented Apr 10, 2023

Copy link
Copy Markdown
Member

@fanyang-mono - We decided to disable the test, mostly as this is a CI failures and not a customer reported issue. We can rethink the actual backport of the fix if there are related issues coming from the field in the future.

@carlossanlop

carlossanlop commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @SamMonoRT. Then it seems this is ready to merge.

I forgot to mention that for tell-mode changes we can automatically add the Servicing-approved label to unblock the check-service-labels CI action and enable the Squash & Merge button.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 10, 2023
@kotlarmilos
kotlarmilos merged commit c885ca4 into dotnet:release/6.0-stagingApr 10, 2023
@kotlarmilos
kotlarmilos deleted the bugfix/disable-hardwareintrinsics-tests branch April 10, 2023 18:01
@antonfirsovantonfirsov mentioned this pull request Apr 13, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@SamMonoRTSamMonoRTSamMonoRT approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
@fanyang-monofanyang-monoAwaiting requested review from fanyang-mono

Assignees

@kotlarmiloskotlarmilos

Labels

area-Codegen-AOT-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.x

Development

Successfully merging this pull request may close these issues.

5 participants

@kotlarmilos@SamMonoRT@fanyang-mono@carlossanlop@steveisok