Skip to content

Add SIMD to LowerCallMemcmp - #84530

Merged
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged

Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:SIMD-LowerCallMemcmp

Conversation

@EgorBo

@EgorBoEgorBo commented Apr 8, 2023

Copy link
Copy Markdown
Member

Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.

boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);

Old codegen:

; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56

New codegen:

; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74

@ghostghost assigned EgorBoApr 8, 2023
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 8, 2023
@ghost

ghost commented Apr 8, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.

boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);

Old codegen:

; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56

New codegen:

; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:

area-CodeGen-coreclr

Milestone:-

tannergooding
tannergooding reviewed Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp
Comment on lines +2044 to +2045
GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);

@tannergoodingtannergoodingApr 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?

@EgorBoEgorBoApr 9, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?

Good idea, done: #84534

@tannergooding

tannergooding commented Apr 9, 2023

Copy link
Copy Markdown
Member

#84536 is the SPMI replay failure

@EgorBo

EgorBo commented Apr 10, 2023

Copy link
Copy Markdown
MemberAuthor

PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp

@EgorBo
EgorBo requested a review from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo merged commit eda1c3a into dotnet:mainApr 10, 2023
@EgorBo
EgorBo deleted the SIMD-LowerCallMemcmp branch April 10, 2023 22:56
sbomer added a commit that referenced this pull request Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer mentioned this pull request Apr 11, 2023
Merged
sbomer added a commit that referenced this pull request Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit to EgorBo/runtime-1 that referenced this pull request Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit that referenced this pull request Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo mentioned this pull request Apr 17, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add SIMD to LowerCallMemcmp by EgorBo · Pull Request #84530 · dotnet/runtime · GitHub
Skip to content
Add SIMD to LowerCallMemcmp - #84530
Merged
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Apr 10, 2023
Merged
Add SIMD to LowerCallMemcmp#84530
EgorBo merged 2 commits into
dotnet:mainfrom 
EgorBo:SIMD-LowerCallMemcmp
Conversation
@EgorBo
@EgorBoEgorBo
commented
Apr 8, 2023

Copy link


Copy Markdown

Member
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
@ghostghost
assigned EgorBoApr 8, 2023
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Apr 8, 2023
@ghost
ghost
commented
Apr 8, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
Add SIMD to unroll length [16..64] (can be enabled for [64..128] with avx512), [16..32] on arm64.
boolTest(Span<byte>s)=>s.SequenceEqual("THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND"u8);
Old codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  4883EC28 subrsp,40G_M52730_IG02:  49B8882A908BDA010000 movr8,0x1DA8B902A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4C89442420 mov bword ptr [rsp+20H],r8 83FA3E cmpedx,627513jne SHORT G_M52730_IG04G_M52730_IG03:  41B83E000000 movr8d,62 488B542420 movrdx, bword ptr [rsp+20H] FF1591FE1600 call[System.SpanHelpers:SequenceEqual(byref,byref,ulong):bool] EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  4883C428 addrsp,40 C3 ret; Total bytes of code: 56
New codegen:
; Method Prog:Test(System.Span`1[ubyte]):bool:thisG_M52730_IG01:  C5F877 vzeroupperG_M52730_IG02:  48B8882A7D01B3020000 movrax,0x2B3017D2A88 488B0A movrcx, bword ptr [rdx] 8B5208 movedx, dword ptr [rdx+08H] 4883FA3E cmprdx,62 752B jne SHORT G_M52730_IG04G_M52730_IG03:  C5FC1001 vmovupsymm0, ymmword ptr[rcx] C5FC1008 vmovupsymm1, ymmword ptr[rax] C5FC10511E vmovupsymm2, ymmword ptr[rcx+1EH] C5FC10581E vmovupsymm3, ymmword ptr[rax+1EH] C5FDEFC1 vpxorymm0,ymm0,ymm1 C5EDEFCB vpxorymm1,ymm2,ymm3 C5FDEBC1 vporymm0,ymm0,ymm1 C4E27D17C0 vptestymm0,ymm0 0F94C0 sete al 0FB6C0 movzxrax,al EB02 jmp SHORT G_M52730_IG05G_M52730_IG04:  33C0 xoreax,eaxG_M52730_IG05:  C5F877 vzeroupper C3 ret; Total bytes of code: 74
Author:EgorBo
Assignees:EgorBo
Labels:
area-CodeGen-coreclr
Milestone:-
tannergooding
tannergooding
reviewed
Apr 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lower.cpp

Comment on lines

+2044
 to 
+2045

 GenTree* rXor = newBinaryOp(comp, GT_XOR, actualLoadType, l2Indir, r2Indir);
 GenTree* resultOr = newBinaryOp(comp, GT_OR, actualLoadType, lXor, rXor);
@tannergoodingtannergoodingApr 9, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
@EgorBoEgorBoApr 9, 2023

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you log an issue tracking us fixing this to opportunistically using vpternlog for AVX-512 hardware?
Good idea, done: #84534
@tannergooding
tannergooding
commented
Apr 9, 2023

Copy link


Copy Markdown

Member
#84536 is the SPMI replay failure
@EgorBo
EgorBo
commented
Apr 10, 2023

Copy link


Copy Markdown

MemberAuthor
PTAL @jakobbotsch since you reviewed the previous impl of LowerCallMemcmp
@EgorBo
EgorBo
requested a review
from jakobbotschApril 10, 2023 09:18
@EgorBo
EgorBo
merged commit eda1c3a
into
dotnet:mainApr 10, 2023
@EgorBo
EgorBo
deleted the

SIMD-LowerCallMemcmp

branch
April 10, 2023 22:56
sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)"
efdd049
This reverts commit eda1c3a.
@sbomersbomer
mentioned this pull request
Apr 11, 2023
 Merged

sbomer added a commit
that referenced
this pull request
Apr 11, 2023
@sbomer
Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)
f8435f4
This reverts commit eda1c3a.
EgorBo added a commit
to EgorBo/runtime-1
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (dotnet#84530)" (dotnet#8…
4bf42a7
…4595)"
EgorBo added a commit
that referenced
this pull request
Apr 11, 2023
@EgorBo
Revert "Revert "Add SIMD to LowerCallMemcmp (#84530)" (#84595)" (#84599)
49b68a9
@EgorBoEgorBo
mentioned this pull request
Apr 17, 2023
 Merged

@ghostghost
locked as resolved and limited conversation to collaborators
May 11, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes
@jakobbotschjakobbotschAwaiting requested review from jakobbotsch

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo@tannergooding