Skip to content

fix gtSplitTree assert - #84634

Merged
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:fix-spmi-assert
Apr 11, 2023
Merged

fix gtSplitTree assert#84634
EgorBo merged 2 commits into
dotnet:mainfrom
EgorBo:fix-spmi-assert

Conversation

@EgorBo

@EgorBoEgorBo commented Apr 11, 2023

Copy link
Copy Markdown
Member

Apply @jakobbotsch's patch

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 11, 2023
@ghostghost assigned EgorBoApr 11, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #84631 ?

Author:EgorBo
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@EgorBo
EgorBo marked this pull request as ready for review April 11, 2023 21:10
@EgorBo

Copy link
Copy Markdown
MemberAuthor

@jakobbotsch can you help me here, I'm a bit confused - the assert is still here or I'm looking at old logs? I was not able to repro it locally after your fix

@tannergooding

Copy link
Copy Markdown
Member

The CI logs are showing the latest PR commit: 89d8c9a

But SPMI is indeed still raising the assert in the logs as well.

@tannergooding

Copy link
Copy Markdown
Member

Ah, and this PR covers only lists (C:\h\w\AA60093B\p\base\checked\clrjit_win_x64_x64.dll)

Where-as the previous lists both a \base\ and a \diff\ set

@BruceForstall

Copy link
Copy Markdown
Contributor

Looks like 5 failures still, in libraries_tests.pmi

@jakobbotsch

Copy link
Copy Markdown
Member

The baseline is going to keep failing until we get new rolling builds with both this and #84588.

@BruceForstall

Copy link
Copy Markdown
Contributor

Ah right, I didn't notice the failure was only in the baseline here. So, ready to merge then?

@EgorBo
EgorBo merged commit a5b143c into dotnet:mainApr 11, 2023
@EgorBo
EgorBo deleted the fix-spmi-assert branch April 11, 2023 23:32
@EgorBo

Copy link
Copy Markdown
MemberAuthor

Thanks! I didn't realize it's the baseline so it confused me a lot 🙂

@EgorBo

Copy link
Copy Markdown
MemberAuthor

I see the a new SPMI is being collected now after Kunal's PR merged today - presumably it will fail because it doesn't have this fix?

@BruceForstall

Copy link
Copy Markdown
Contributor

SPMI collection itself won't fail; it will filter out any JIT failures.

We'll want to re-run collection after both fixes (this and #84588) are merged. Also, we need to wait until #84649 is merged

@ghostghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@tannergooding@BruceForstall@jakobbotsch