Skip to content

Fix x64 macOS and Linux managed debugging - #84655

Merged
mikem8361 merged 4 commits into
dotnet:mainfrom
tommcdon:dev/tommcdon/fixx64macdbg
Apr 15, 2023
Merged

Fix x64 macOS and Linux managed debugging#84655
mikem8361 merged 4 commits into
dotnet:mainfrom
tommcdon:dev/tommcdon/fixx64macdbg

Conversation

@tommcdon

@tommcdontommcdon commented Apr 11, 2023

Copy link
Copy Markdown
Member

A recent change to T_CONTEXT size breaks managed debugging. This addresses the necessary debugger API's to unblock managed debugging.

Fixes#84466

@tommcdon
tommcdon requested a review from mikem8361April 11, 2023 21:22
@ghostghost assigned tommcdonApr 11, 2023
@ghost

ghost commented Apr 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

A recent change to T_CONTEXT size breaks managed debugging. This addresses the necessary debugger API's to unblock managed debugging.

Fixes #84466

Author:tommcdon
Assignees:-
Labels:

area-Diagnostics-coreclr

Milestone:-

@tommcdontommcdon added this to the 8.0.0 milestone Apr 11, 2023
@tommcdon
tommcdon marked this pull request as draft April 11, 2023 21:22
@tommcdon
tommcdon requested a review from hoyosjsApril 11, 2023 21:22
@tannergooding

tannergooding commented Apr 11, 2023

Copy link
Copy Markdown
Member

This was probably caused by my thread suspend/restore changes, sorry!

Is there anything we can do to catch such breaks in the future?

@tommcdon

tommcdon commented Apr 11, 2023

Copy link
Copy Markdown
MemberAuthor

Hi @tannergooding! No worries! We have tests in the dotnet/diagnostics repo that would catch this issue but there were unrelated problems that was preventing a runtime update. Our plan/thinking to address this in the future is to add some static asserts to the code that would at least alert folks to the debugger's dependency on context sizes.

@mikem8361
mikem8361force-pushed the dev/tommcdon/fixx64macdbg branch from 38d6b34 to 24ec334CompareApril 14, 2023 03:50
@mikem8361
mikem8361force-pushed the dev/tommcdon/fixx64macdbg branch from 24ec334 to faefa50CompareApril 14, 2023 03:51
@build-analysisbuild-analysisBot mentioned this pull request Apr 14, 2023
Closed
@mikem8361
mikem8361 marked this pull request as ready for review April 14, 2023 16:39
tommcdon
tommcdon commented Apr 14, 2023
View reviewed changes

@tommcdontommcdon left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for your consideration otherwise the changes look good to me! I would approve the PR but I am unable to as I am the owner of it :).

Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
Comment threadsrc/coreclr/debug/daccess/dacdbiimpl.cpp
@mikem8361mikem8361 self-assigned this Apr 14, 2023
@mikem8361
mikem8361 merged commit 49af07c into dotnet:mainApr 15, 2023
@clamp03clamp03 mentioned this pull request Apr 17, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjshoyosjsAwaiting requested review from hoyosjs
1 more reviewer
@mikem8361mikem8361mikem8361 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mikem8361mikem8361

@tommcdontommcdon

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[NETSDKE2E] With .NET 8.0 Preview4, debugging does not work normally on Mac X64

3 participants

@tommcdon@tannergooding@mikem8361