Uh oh!
There was an error while loading. Please reload this page.
[Release/7.0] Port EventCounters multi session support to 7.0 - #84679
Merged
Conversation
jeffschwMSFT
approved these changes
Apr 12, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x. please get a code review
This was referenced Apr 12, 2023
noahfalk
approved these changes
Apr 14, 2023
noahfalk
left a comment
Member
There was a problem hiding this comment.
Same as the 6.0 PR. Behavior looks correct but ideally we'd not include the refactoring parts of the change that don't modify the final behavior.
carlossanlop
commented
May 4, 2023
Contributor
@davmason - Reminder that you're free to merge your PR to the staging branch anytime, as long as:
If you want this fix to go into the June Release, please make sure to merge this before the code complete day (May 15th). |
This was referenced May 4, 2023
davmason
commented
May 9, 2023
ContributorAuthor
Rebasing against release/7.0-staging latest to trigger a new CI run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #82970 to 7.0
Customer Impact
Currently multiple different EventCounters sessions can be started but when any session stops we stop emitting counters for all events. This is true for dotnet-counters and manually enabling counters via in an process EventListener or via ETW/EventPipe/LTTNG.
We have quite a few internal and external teams using EventCounters, so as time goes on we find that they are disabling each other's sessions more and more. We have received requests from internal and external partners that this be fixed in servicing.
Testing
Partner team validation that it fixes their scenario.
Risk
This fix includes a minor breaking change as described in #84586. We previously would issue callbacks for EventSource Disable events before we fully marked the EventSource as disabled, but after we disallowed any further events from being sent. With this change we will issue callbacks after we mark the EventSource as fully disabled.
I cannot think of a scenario this would break, but it is different behavior and could theoretically cause issues for customers.