Skip to content

[browser] Wasm SDK packed as a nuget package - #84761

Merged
lewing merged 2 commits into
dotnet:mainfrom
maraf:WasmSdkPackaged2
Apr 14, 2023
Merged

[browser] Wasm SDK packed as a nuget package#84761
lewing merged 2 commits into
dotnet:mainfrom
maraf:WasmSdkPackaged2

Conversation

@maraf

@marafmaraf commented Apr 13, 2023

Copy link
Copy Markdown
Member

Produce a Microsoft.NET.Sdk.WebAssembly.Pack package containing most of the Wasm SDK bits.

Contributes to #81367
Fixes#84742

@marafmaraf added arch-wasm WebAssembly architecture area-Build-mono labels Apr 13, 2023
@marafmaraf added this to the 8.0.0 milestone Apr 13, 2023
@marafmaraf self-assigned this Apr 13, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Produce a Microsoft.NET.Sdk.WebAssembly.Pack package containing most of the Wasm SDK bits.
Original PR #84082

  • Original sources https://github.com/dotnet/sdk/tree/main/src/WasmSdk
  • This PR tries to make a minimal change
  • Tests and integration with in-tree building will come in follow-up PRs
  • Update pattern for matching RidAgnosticNupkgToPublishFile to include Microsoft.NET.Sdk.WebAssembly.Pack

Contributes to #81367

Author:maraf
Assignees:maraf
Labels:

arch-wasm, area-Build-mono

Milestone:8.0.0

@maraf

Copy link
Copy Markdown
MemberAuthor

@maraf

maraf commented Apr 13, 2023

Copy link
Copy Markdown
MemberAuthor

The official build has completed and I have validated in binlog that the items collection ItemsToPush contains Microsoft.NET.Sdk.WebAssembly.Pack. The task PushToAzureDevOpsArtifacts doesn't run for branch build.

Failures are not related

@lewing This is ready to merge

@maraf

Copy link
Copy Markdown
MemberAuthor

We should wait for this dotnet/sdk#31559 to land in SDK and update StaticWebAssets binding

@lewing
lewing merged commit 27b8a24 into dotnet:mainApr 14, 2023
@maraf
maraf deleted the WasmSdkPackaged2 branch April 14, 2023 06:50
@ghostghost locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Official build failure trying to sign Microsoft.NET.Sdk.WebAssembly.Pack

2 participants

@maraf@lewing