Skip to content

[release/6.0] Move mono.mscordbi subset off the offical build - #84939

Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from
steveisok:move-mscordbi-60
Apr 17, 2023
Merged

[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from
steveisok:move-mscordbi-60

Conversation

@steveisok

@steveisoksteveisok commented Apr 17, 2023

Copy link
Copy Markdown
Member

Backport of #81917

This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.

@steveisok

steveisok commented Apr 17, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop this is a tell-mode change.

@steveisok
steveisok requested a review from thaystgApril 17, 2023 18:30
@steveisok

steveisok commented Apr 17, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.

@carlossanlop
carlossanlop changed the base branch from release/6.0-staging to release/6.0April 17, 2023 19:09
@carlossanlop

carlossanlop commented Apr 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.

Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.

Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Apr 17, 2023
@carlossanlop

carlossanlop commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

One of the wasm failures has this message:

/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?

If it's different, let me know so I open a new issue.

@carlossanlopcarlossanlop mentioned this pull request Apr 17, 2023
Closed
@carlossanlop

carlossanlop commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023
Closed
Closed
@carlossanlopcarlossanlop mentioned this pull request Apr 17, 2023
Closed
This was referenced Apr 17, 2023
Closed
Open
@carlossanlop
carlossanlop merged commit 75ce69d into dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot mentioned this pull request Apr 17, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/6.0] Move mono.mscordbi subset off the offical build by steveisok · Pull Request #84939 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Move mono.mscordbi subset off the offical build - #84939
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Apr 17, 2023
Merged
[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Conversation
@steveisok
@steveisoksteveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

Member
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is a tell-mode change.
@steveisok
steveisok
requested a review
from thaystgApril 17, 2023 18:30
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0-staging
to
release/6.0April 17, 2023 19:09
@carlossanlop
carlossanlop
commented
Apr 17, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.
Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.
Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Apr 17, 2023
@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
One of the wasm failures has this message:
/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?
If it's different, let me know so I open a new issue.
@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed

@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023

Closed


Closed

@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed


This was referenced Apr 17, 2023

Closed


Open

@carlossanlop
carlossanlop
merged commit 75ce69d
into
dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 17, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Move mono.mscordbi subset off the offical build by steveisok · Pull Request #84939 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Move mono.mscordbi subset off the offical build - #84939
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Apr 17, 2023
Merged
[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Conversation
@steveisok
@steveisoksteveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

Member
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is a tell-mode change.
@steveisok
steveisok
requested a review
from thaystgApril 17, 2023 18:30
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0-staging
to
release/6.0April 17, 2023 19:09
@carlossanlop
carlossanlop
commented
Apr 17, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.
Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.
Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Apr 17, 2023
@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
One of the wasm failures has this message:
/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?
If it's different, let me know so I open a new issue.
@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed

@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023

Closed


Closed

@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed


This was referenced Apr 17, 2023

Closed


Open

@carlossanlop
carlossanlop
merged commit 75ce69d
into
dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 17, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Move mono.mscordbi subset off the offical build by steveisok · Pull Request #84939 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Move mono.mscordbi subset off the offical build - #84939
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Apr 17, 2023
Merged
[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Conversation
@steveisok
@steveisoksteveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

Member
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is a tell-mode change.
@steveisok
steveisok
requested a review
from thaystgApril 17, 2023 18:30
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0-staging
to
release/6.0April 17, 2023 19:09
@carlossanlop
carlossanlop
commented
Apr 17, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.
Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.
Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Apr 17, 2023
@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
One of the wasm failures has this message:
/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?
If it's different, let me know so I open a new issue.
@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed

@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023

Closed


Closed

@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed


This was referenced Apr 17, 2023

Closed


Open

@carlossanlop
carlossanlop
merged commit 75ce69d
into
dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 17, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/6.0] Move mono.mscordbi subset off the offical build by steveisok · Pull Request #84939 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Move mono.mscordbi subset off the offical build - #84939
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Apr 17, 2023
Merged
[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Conversation
@steveisok
@steveisoksteveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

Member
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is a tell-mode change.
@steveisok
steveisok
requested a review
from thaystgApril 17, 2023 18:30
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0-staging
to
release/6.0April 17, 2023 19:09
@carlossanlop
carlossanlop
commented
Apr 17, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.
Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.
Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Apr 17, 2023
@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
One of the wasm failures has this message:
/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?
If it's different, let me know so I open a new issue.
@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed

@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023

Closed


Closed

@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed


This was referenced Apr 17, 2023

Closed


Open

@carlossanlop
carlossanlop
merged commit 75ce69d
into
dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 17, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Move mono.mscordbi subset off the offical build by steveisok · Pull Request #84939 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Move mono.mscordbi subset off the offical build - #84939
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Apr 17, 2023
Merged
[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Conversation
@steveisok
@steveisoksteveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

Member
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is a tell-mode change.
@steveisok
steveisok
requested a review
from thaystgApril 17, 2023 18:30
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0-staging
to
release/6.0April 17, 2023 19:09
@carlossanlop
carlossanlop
commented
Apr 17, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.
Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.
Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Apr 17, 2023
@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
One of the wasm failures has this message:
/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?
If it's different, let me know so I open a new issue.
@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed

@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023

Closed


Closed

@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed


This was referenced Apr 17, 2023

Closed


Open

@carlossanlop
carlossanlop
merged commit 75ce69d
into
dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 17, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/6.0] Move mono.mscordbi subset off the offical build by steveisok · Pull Request #84939 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Move mono.mscordbi subset off the offical build - #84939
Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Apr 17, 2023
Merged
[release/6.0] Move mono.mscordbi subset off the offical build#84939
carlossanlop merged 1 commit into
dotnet:release/6.0from 
steveisok:move-mscordbi-60
Conversation
@steveisok
@steveisoksteveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

Member
Backport of #81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop this is a tell-mode change.
@steveisok
steveisok
requested a review
from thaystgApril 17, 2023 18:30
@steveisok
steveisok
commented
Apr 17, 2023

Copy link


Copy Markdown

MemberAuthor
@carlossanlop@mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.
@carlossanlop
carlossanlop
changed the base branch from
release/6.0-staging
to
release/6.0April 17, 2023 19:09
@carlossanlop
carlossanlop
commented
Apr 17, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.
Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.
Steve Pfister@carlossanlop
[release/6.0] Move mono.mscordbi subset off the offical build
5dedb13
Backport of dotnet#81917
This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlopcarlossanlop
added
the 
Servicing-approved
Approved for servicing release
label
Apr 17, 2023
@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
One of the wasm failures has this message:
/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
console.info: Arguments: --run,DllImportSearchPathsTest.dll
console.debug: MONO_WASM: Initializing mono runtime
console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
console.info: Initializing.....
Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
at System.IO.Path.Combine(String path1, String path2)
at DllImportSearchPathsTest.get_Subdirectory()
at DllImportSearchPathsTest.AssemblyDirectory_Found()
at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung@lewing can you confirm it's the exact same issue?
If it's different, let me know so I open a new issue.
@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed

@carlossanlop
carlossanlop
commented
Apr 17, 2023

Copy link


Copy Markdown

Contributor
Other failures which the known build problem is not linking:

This was referenced Apr 17, 2023

Closed


Closed

@carlossanlopcarlossanlop
mentioned this pull request
Apr 17, 2023

Closed


This was referenced Apr 17, 2023

Closed


Open

@carlossanlop
carlossanlop
merged commit 75ce69d
into
dotnet:release/6.0Apr 17, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Apr 17, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
May 18, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@thaystgthaystgthaystg approved these changes
@hoyosjshoyosjshoyosjs approved these changes
@lewinglewingAwaiting requested review from lewing

+1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area-Infrastructure-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@steveisok@carlossanlop@thaystg@hoyosjs