Skip to content

[wasi] Fix support for paths with spaces - #85022

Merged
radical merged 4 commits into
dotnet:mainfrom
radical:wasi-wbt-spaces
Apr 27, 2023
Merged

[wasi] Fix support for paths with spaces#85022
radical merged 4 commits into
dotnet:mainfrom
radical:wasi-wbt-spaces

Conversation

@radical

@radicalradical commented Apr 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member
  • Fix running tests locally
  • TODO: Add spaces for the sdk installed directory name too

Fixes#84878

@radicalradical added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code os-wasi Related to WASI variant of arch-wasm labels Apr 19, 2023
@radical
radical requested review from lewing and marafApril 19, 2023 00:17
@ghostghost added the area-Build-mono label Apr 19, 2023
@ghostghost assigned radicalApr 19, 2023
@ghost

ghost commented Apr 19, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use a directory name containing spaces for WBT
  • Fix running tests locally
  • TODO: Add spaces for the sdk installed directory name too

Fixes #84878

Author:radical
Assignees:-
Labels:

arch-wasm, test-enhancement, os-wasi

Milestone:-

@radical

radical commented Apr 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Apr 19, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Apr 19, 2023
Closed
@radical
radical marked this pull request as draft April 19, 2023 15:26
@radical
radical marked this pull request as ready for review April 27, 2023 15:58
lewing
lewing reviewed Apr 27, 2023
View reviewed changes
Comment threadsrc/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj
@build-analysisbuild-analysisBot mentioned this pull request Apr 27, 2023
Closed
@radical

radical commented Apr 27, 2023

Copy link
Copy Markdown
MemberAuthor

Failures are known, and unrelated.

@radical
radical merged commit 0c612cf into dotnet:mainApr 27, 2023
@radical
radical deleted the wasi-wbt-spaces branch April 27, 2023 20:07
@lewing

lewing commented May 9, 2023

Copy link
Copy Markdown
Member

/backport to release/8.0-preview4

@github-actions

github-actionsBot commented May 9, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0-preview4: https://github.com/dotnet/runtime/actions/runs/4928677357

@github-actionsgithub-actionsBot mentioned this pull request May 9, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-wasiRelated to WASI variant of arch-wasmtest-enhancementImprovements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasi] Unescaped file paths when compiling with WasmSingleFileBundle

2 participants

@radical@lewing