Skip to content

Revert "[mono][aot] Enable deduplication of runtime invoke wrappers" - #85048

Merged
kotlarmilos merged 1 commit into
mainfrom
revert-84304-improvement/dedup-runtime-invoke-wrappers
Apr 19, 2023
Merged

Revert "[mono][aot] Enable deduplication of runtime invoke wrappers"#85048
kotlarmilos merged 1 commit into
mainfrom
revert-84304-improvement/dedup-runtime-invoke-wrappers

Conversation

@kotlarmilos

Copy link
Copy Markdown
Member

Reverts #84304. This PR produced regression reported in dotnet/perf-autofiling-issues#16477.

@lambdageek

Copy link
Copy Markdown
Member

Do we prefer this over #85044 ?

@kotlarmilos

kotlarmilos commented Apr 19, 2023

Copy link
Copy Markdown
MemberAuthor

As it was a code refactor, I think we could proceed with this PR (full revert) over #85044 (partial revert), and introduce the fixed version after the snap.

/cc: @vargaz

@kotlarmilos
kotlarmilos merged commit 693663b into mainApr 19, 2023
@kotlarmilos
kotlarmilos deleted the revert-84304-improvement/dedup-runtime-invoke-wrappers branch April 19, 2023 17:12
@ghostghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kotlarmilos@lambdageek@vargaz