Skip to content

[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062

Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom
thaystg:thays_fix_1784268
Apr 24, 2023
Merged

[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom
thaystg:thays_fix_1784268

Conversation

@thaystg

@thaystgthaystg commented Apr 19, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

Only skipping printing the error if we have an exception of type: WebSocketException

Customer Impact

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268
When the browser is closed an exception is printed to console.
image

Regression

Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.

Testing

Manually tested

Risk

Low risk. Only not printing the error.

Package authoring signed off?

N/A

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghostghost assigned thaystgApr 19, 2023
@ghost

ghost commented Apr 19, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Only skipping printing the error if we have an exception of type: WebSocketException

Customer Impact

When the browser is closed an exception is printed to console.
image

Regression

Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.

Testing

Manually tested

Risk

Low risk. Only not printing the error.

Package authoring signed off?

N/A

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystg
thaystg requested a review from radicalApril 19, 2023 18:59
@thaystgthaystg changed the title [wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot mentioned this pull request Apr 19, 2023
Closed
This was referenced Apr 19, 2023
Open
Closed
Closed
@lewing

lewing commented Apr 20, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@carlossanlop failures here are known

@lewinglewing added the Servicing-consider Issue for next servicing release review label Apr 20, 2023
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 20, 2023
@rbhandarbhanda modified the milestones: 6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg merged commit a81beb7 into dotnet:release/6.0-stagingApr 24, 2023
@ghostghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed by thaystg · Pull Request #85062 · dotnet/runtime · GitHub
Skip to content
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062
Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Apr 24, 2023
Merged
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Conversation
@thaystg
@thaystgthaystg
commented
Apr 19, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268

When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
@ghostghost
assigned thaystgApr 19, 2023
@ghost
ghost
commented
Apr 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @thaystg

See info in area-owners.md if you want to be subscribed.
Issue Details
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Author:thaystg
Assignees:-
Labels:
area-Debugger-mono
Milestone:-
@thaystg
thaystg
requested a review
from radicalApril 19, 2023 18:59
@thaystgthaystg
changed the title
[wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot
mentioned this pull request
Apr 19, 2023

Closed


This was referenced Apr 19, 2023

Open


Closed


Closed

@lewing
lewing
commented
Apr 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@carlossanlop failures here are known
@lewinglewing
added
the 
Servicing-consider
Issue for next servicing release review
label
Apr 20, 2023
@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Apr 20, 2023
@rbhandarbhanda
modified the milestones:
6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg
merged commit a81beb7
into
dotnet:release/6.0-stagingApr 24, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed by thaystg · Pull Request #85062 · dotnet/runtime · GitHub
Skip to content
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062
Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Apr 24, 2023
Merged
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Conversation
@thaystg
@thaystgthaystg
commented
Apr 19, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268

When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
@ghostghost
assigned thaystgApr 19, 2023
@ghost
ghost
commented
Apr 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @thaystg

See info in area-owners.md if you want to be subscribed.
Issue Details
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Author:thaystg
Assignees:-
Labels:
area-Debugger-mono
Milestone:-
@thaystg
thaystg
requested a review
from radicalApril 19, 2023 18:59
@thaystgthaystg
changed the title
[wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot
mentioned this pull request
Apr 19, 2023

Closed


This was referenced Apr 19, 2023

Open


Closed


Closed

@lewing
lewing
commented
Apr 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@carlossanlop failures here are known
@lewinglewing
added
the 
Servicing-consider
Issue for next servicing release review
label
Apr 20, 2023
@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Apr 20, 2023
@rbhandarbhanda
modified the milestones:
6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg
merged commit a81beb7
into
dotnet:release/6.0-stagingApr 24, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed by thaystg · Pull Request #85062 · dotnet/runtime · GitHub
Skip to content
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062
Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Apr 24, 2023
Merged
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Conversation
@thaystg
@thaystgthaystg
commented
Apr 19, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268

When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
@ghostghost
assigned thaystgApr 19, 2023
@ghost
ghost
commented
Apr 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @thaystg

See info in area-owners.md if you want to be subscribed.
Issue Details
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Author:thaystg
Assignees:-
Labels:
area-Debugger-mono
Milestone:-
@thaystg
thaystg
requested a review
from radicalApril 19, 2023 18:59
@thaystgthaystg
changed the title
[wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot
mentioned this pull request
Apr 19, 2023

Closed


This was referenced Apr 19, 2023

Open


Closed


Closed

@lewing
lewing
commented
Apr 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@carlossanlop failures here are known
@lewinglewing
added
the 
Servicing-consider
Issue for next servicing release review
label
Apr 20, 2023
@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Apr 20, 2023
@rbhandarbhanda
modified the milestones:
6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg
merged commit a81beb7
into
dotnet:release/6.0-stagingApr 24, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed by thaystg · Pull Request #85062 · dotnet/runtime · GitHub
Skip to content
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062
Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Apr 24, 2023
Merged
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Conversation
@thaystg
@thaystgthaystg
commented
Apr 19, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268

When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
@ghostghost
assigned thaystgApr 19, 2023
@ghost
ghost
commented
Apr 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @thaystg

See info in area-owners.md if you want to be subscribed.
Issue Details
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Author:thaystg
Assignees:-
Labels:
area-Debugger-mono
Milestone:-
@thaystg
thaystg
requested a review
from radicalApril 19, 2023 18:59
@thaystgthaystg
changed the title
[wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot
mentioned this pull request
Apr 19, 2023

Closed


This was referenced Apr 19, 2023

Open


Closed


Closed

@lewing
lewing
commented
Apr 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@carlossanlop failures here are known
@lewinglewing
added
the 
Servicing-consider
Issue for next servicing release review
label
Apr 20, 2023
@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Apr 20, 2023
@rbhandarbhanda
modified the milestones:
6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg
merged commit a81beb7
into
dotnet:release/6.0-stagingApr 24, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed by thaystg · Pull Request #85062 · dotnet/runtime · GitHub
Skip to content
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062
Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Apr 24, 2023
Merged
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Conversation
@thaystg
@thaystgthaystg
commented
Apr 19, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268

When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
@ghostghost
assigned thaystgApr 19, 2023
@ghost
ghost
commented
Apr 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @thaystg

See info in area-owners.md if you want to be subscribed.
Issue Details
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Author:thaystg
Assignees:-
Labels:
area-Debugger-mono
Milestone:-
@thaystg
thaystg
requested a review
from radicalApril 19, 2023 18:59
@thaystgthaystg
changed the title
[wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot
mentioned this pull request
Apr 19, 2023

Closed


This was referenced Apr 19, 2023

Open


Closed


Closed

@lewing
lewing
commented
Apr 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@carlossanlop failures here are known
@lewinglewing
added
the 
Servicing-consider
Issue for next servicing release review
label
Apr 20, 2023
@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Apr 20, 2023
@rbhandarbhanda
modified the milestones:
6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg
merged commit a81beb7
into
dotnet:release/6.0-stagingApr 24, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed by thaystg · Pull Request #85062 · dotnet/runtime · GitHub
Skip to content
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed - #85062
Merged
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Apr 24, 2023
Merged
[release/6.0-staging][wasm][debugger] Remove error message when browser is closed#85062
thaystg merged 2 commits into
dotnet:release/6.0-stagingfrom 
thaystg:thays_fix_1784268
Conversation
@thaystg
@thaystgthaystg
commented
Apr 19, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268

When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
@ghostghost
assigned thaystgApr 19, 2023
@ghost
ghost
commented
Apr 19, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @thaystg

See info in area-owners.md if you want to be subscribed.
Issue Details
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
When the browser is closed an exception is printed to console.
image
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
Author:thaystg
Assignees:-
Labels:
area-Debugger-mono
Milestone:-
@thaystg
thaystg
requested a review
from radicalApril 19, 2023 18:59
@thaystgthaystg
changed the title
[wasm][debugger] Remove error message when browser is closed[release/6.0-staging][wasm][debugger] Remove error message when browser is closedApr 19, 2023
@runfoapprunfoappBot
mentioned this pull request
Apr 19, 2023

Closed


This was referenced Apr 19, 2023

Open


Closed


Closed

@lewing
lewing
commented
Apr 20, 2023•

edited

Loading

Copy link


Copy Markdown

Member
@carlossanlop failures here are known
@lewinglewing
added
the 
Servicing-consider
Issue for next servicing release review
label
Apr 20, 2023
@rbhandarbhanda
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Apr 20, 2023
@rbhandarbhanda
modified the milestones:
6.0.17, 6.0.18Apr 20, 2023
@thaystg
thaystg
merged commit a81beb7
into
dotnet:release/6.0-stagingApr 24, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@thaystg@lewing@radical@rbhanda