Skip to content

Add a test for STORE_DYN_BLK(..., IND(null), ...) - #85103

Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom
SingleAccretion:DynBlk-Assertions-Test
Apr 23, 2023
Merged

Add a test for STORE_DYN_BLK(..., IND(null), ...)#85103
jakobbotsch merged 1 commit into
dotnet:mainfrom
SingleAccretion:DynBlk-Assertions-Test

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

The underlying problem was fixed by marking the source indirection with NO_CSE in #83814.

Closes#62328.

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Apr 20, 2023
@ghost

ghost commented Apr 20, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

The underlying problem was fixed by marking the source indirection with NO_CSE in #83814.

Closes #62328.

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@build-analysisbuild-analysisBot mentioned this pull request Apr 20, 2023
Closed
@SingleAccretion

SingleAccretion commented Apr 20, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

browser-wasm linux Release AllSubsets_Mono_RuntimeTests monointerpreter failure is #80619.

Just adding test for a fixed issue.

@dotnet/jit-contrib

@jakobbotsch

jakobbotsch commented Apr 21, 2023

Copy link
Copy Markdown
Member

Looks like license/cla is stuck, need to bounce it.

@jakobbotsch
jakobbotsch merged commit e8c4971 into dotnet:mainApr 23, 2023
@SingleAccretion
SingleAccretion deleted the DynBlk-Assertions-Test branch May 1, 2023 15:12
@ghostghost locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dynamic block nodes should not generate non-null assertions

2 participants

@SingleAccretion@jakobbotsch