Skip to content

Enable StripSymbols by default - #85139

Merged
MichalStrehovsky merged 4 commits into
dotnet:mainfrom
MichalStrehovsky:stripsym
Apr 23, 2023
Merged

Enable StripSymbols by default#85139
MichalStrehovsky merged 4 commits into
dotnet:mainfrom
MichalStrehovsky:stripsym

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

See discussion in dotnet/sdk#31739 (comment).

Once this merges, we should:

  • Update the dotnet new console -aot template
  • Update the dotnet new api -aot template
  • Update docs and declare different defaults in 8.0.

Cc @dotnet/ilc-contrib @am11@DamianEdwards@eerhardt

See discussion in dotnet/sdk#31739 (comment).
Once this merges, we should:
- [ ] Update the `dotnet new console -aot` template
- [ ] Update the `dotnet new api -aot` template
- [ ] Update docs and declare different defaults.
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

See discussion in dotnet/sdk#31739 (comment).

Once this merges, we should:

  • Update the dotnet new console -aot template
  • Update the dotnet new api -aot template
  • Update docs and declare different defaults in 8.0.

Cc @dotnet/ilc-contrib @am11@DamianEdwards@eerhardt

Author:MichalStrehovsky
Assignees:-
Labels:

area-NativeAOT-coreclr

Milestone:-

@MichalStrehovskyMichalStrehovsky added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Apr 21, 2023
@ghostghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 21, 2023
@ghost

ghost commented Apr 21, 2023

Copy link
Copy Markdown

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MichalStrehovsky

Copy link
Copy Markdown
MemberAuthor

Cc @kotlarmilos@akoeplinger looks like there's an issue with the GenerateUnmanagedEntrypoints test when stripsymbols is specified. A wild guess is that this strips the symbols we actually need. Don't have a mac around to investigate. I'm going to enable StripSymbols on the test on mac so that we don't block this since GenerateUnmanagedEntrypoints is not an end user scenario.

 BEGIN EXECUTION
/tmp/helix/working/A662095E/p/nativeaottest.sh /private/tmp/helix/working/A662095E/w/B46609F8/e/nativeaot/GenerateUnmanagedEntryPoints/GenerateUnmanagedEntryPoints/ GenerateUnmanagedEntryPoints.dll ''
Expected: 100
Actual: 2
END EXECUTION - FAILED

@MichalStrehovsky

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
MichalStrehovsky merged commit 8c2c15b into dotnet:mainApr 23, 2023
@MichalStrehovsky
MichalStrehovsky deleted the stripsym branch April 23, 2023 07:24
@MichalStrehovskyMichalStrehovsky removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 24, 2023
@ivanpovazan

Copy link
Copy Markdown
Member

Cc @kotlarmilos@akoeplinger looks like there's an issue with the GenerateUnmanagedEntrypoints test when stripsymbols is specified. A wild guess is that this strips the symbols we actually need. Don't have a mac around to investigate. I'm going to enable StripSymbols on the test on mac so that we don't block this since GenerateUnmanagedEntrypoints is not an end user scenario.

 BEGIN EXECUTION
/tmp/helix/working/A662095E/p/nativeaottest.sh /private/tmp/helix/working/A662095E/w/B46609F8/e/nativeaot/GenerateUnmanagedEntryPoints/GenerateUnmanagedEntryPoints/ GenerateUnmanagedEntryPoints.dll ''
Expected: 100
Actual: 2
END EXECUTION - FAILED

I can look into this, as I added the test case.

@kotlarmilos

Copy link
Copy Markdown
Member

Cc @kotlarmilos@akoeplinger looks like there's an issue with the GenerateUnmanagedEntrypoints test when stripsymbols is specified. A wild guess is that this strips the symbols we actually need. Don't have a mac around to investigate. I'm going to enable StripSymbols on the test on mac so that we don't block this since GenerateUnmanagedEntrypoints is not an end user scenario.

 BEGIN EXECUTION
/tmp/helix/working/A662095E/p/nativeaottest.sh /private/tmp/helix/working/A662095E/w/B46609F8/e/nativeaot/GenerateUnmanagedEntryPoints/GenerateUnmanagedEntryPoints/ GenerateUnmanagedEntryPoints.dll ''
Expected: 100
Actual: 2
END EXECUTION - FAILED

I can look into this, as I added the test case.

@ivanpovazan Thanks! Let me know if the failure is caused by particular stripping options introduced in #81361.

@ghostghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-NativeAOT-coreclrbreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MichalStrehovsky@ivanpovazan@kotlarmilos@jkotas