Uh oh!
There was an error while loading. Please reload this page.
Fix exception leaking from filter in nativeAOT - #85366
Conversation
There is a bug in handling exceptions that occur in exception filters in nativeAOT. If such exception is not handled in the filter, it needs to be swallowed and the filter should behave as if it returned `false`. Instead of that, the current behavior is that debug build of the runtime asserts and the release build fails fast without any message. This change fixes it by catching the exception in the exception handling code. It was also necessary to modify the stack frame iterator to let it unwind past the filter funclet instead of failing fast.
ghost
commented
Apr 25, 2023
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThere is a bug in handling exceptions that occur in exception filters in nativeAOT. If such exception is not handled in the filter, it needs to be swallowed and the filter should behave as if it returned This change fixes it by catching the exception in the exception handling code. It was also necessary to modify the stack frame iterator to let it unwind past the filter funclet instead of failing fast.
|
Uh oh!
There was an error while loading. Please reload this page.
janvorli
commented
Apr 26, 2023
Test failure is a known issue: #84821 |
There is a bug in handling exceptions that occur in exception filters in nativeAOT. If such exception is not handled in the filter, it needs to be swallowed and the filter should behave as if it returned
false. Instead of that, the current behavior is that debug build of the runtime asserts and the release build fails fast without any message.This change fixes it by catching the exception in the exception handling code. It was also necessary to modify the stack frame iterator to let it unwind past the filter funclet instead of failing fast.
Closedotnet/runtimelab#188