Skip to content

[NodeJS] Enable wasm exception handling for unit tests - #85387

Merged
pavelsavara merged 1 commit into
dotnet:mainfrom
pavelsavara:nodejs_enable_eh
Apr 26, 2023
Merged

[NodeJS] Enable wasm exception handling for unit tests#85387
pavelsavara merged 1 commit into
dotnet:mainfrom
pavelsavara:nodejs_enable_eh

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Apr 26, 2023

Copy link
Copy Markdown
Member

In order to fix Log

CompileError: WebAssembly.instantiate(): unexpected section <Tag> (enable with --experimental-wasm-eh) @+16822

@radekdoulik do we need to do something about console host and the template too ?

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test labels Apr 26, 2023
@pavelsavarapavelsavara added this to the 8.0.0 milestone Apr 26, 2023
@pavelsavarapavelsavara self-assigned this Apr 26, 2023
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 26, 2023
@ghost

ghost commented Apr 26, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In order to fix Log

CompileError: WebAssembly.instantiate(): unexpected section <Tag> (enable with --experimental-wasm-eh) @+16822

@radekdoulik do we need to do something about console host and the template too ?

Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, wasm-aot-test

Milestone:8.0.0

@pavelsavara

pavelsavara commented Apr 26, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Apr 26, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavarapavelsavara added area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 26, 2023
@pavelsavara

pavelsavara commented Apr 26, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This is log after this fix where the same test passed.

Other failures are unrelated.

@pavelsavara
pavelsavara marked this pull request as ready for review April 26, 2023 12:23
radekdoulik
radekdoulik approved these changes Apr 26, 2023
View reviewed changes

@radekdoulikradekdoulik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekdoulik

radekdoulik commented Apr 26, 2023

Copy link
Copy Markdown
Member

@radekdoulik do we need to do something about console host and the template too ?

I think we already handle it here https://github.com/dotnet/runtime/blob/main/src/mono/wasm/templates/templates/console/runtimeconfig.template.json#L10

@pavelsavara
pavelsavara merged commit 342c4ed into dotnet:mainApr 26, 2023
This was referenced Apr 26, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators May 26, 2023
@pavelsavara
pavelsavara deleted the nodejs_enable_eh branch September 2, 2024 15:30
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radekdoulikradekdoulikradekdoulik approved these changes
@lewinglewingAwaiting requested review from lewing
@marafmarafAwaiting requested review from maraf

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-Build-monowasm-aot-testWebAssembly AOT Test

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara@radekdoulik