') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/6.0] Fix createdump arg parsing for signal-based exceptions by hoyosjs · Pull Request #85425 · dotnet/runtime · GitHub
Skip to content

[release/6.0] Fix createdump arg parsing for signal-based exceptions - #85425

Merged
hoyosjs merged 1 commit into
dotnet:release/6.0-stagingfrom
hoyosjs:juhoyosa/fix-createdump-args-6
Apr 27, 2023
Merged

[release/6.0] Fix createdump arg parsing for signal-based exceptions#85425
hoyosjs merged 1 commit into
dotnet:release/6.0-stagingfrom
hoyosjs:juhoyosa/fix-createdump-args-6

Conversation

@hoyosjs

@hoyosjshoyosjs commented Apr 26, 2023

Copy link
Copy Markdown
Member

Backport of #85422 to release/7.0-staging

Handle NT_SIGINFO parameters on macOS for hardware-signal based exceptions.

/cc @hoyosjs

Customer Impact

This was a regression w.r.t 7.0.4 and 6.0.15. The regression caused no dumps or crash reports to be generated for crashes on hardware exceptions.

Testing

Testing in automation to be added out of band. Reported scenarios validated manually.

Risk

Low risk - linux uses the same parsing logic, and the values don't get used if not needed (macOS doesn't try to use the values).

@hoyosjs
hoyosjs requested a review from mikem8361April 26, 2023 22:26
@ghost

ghost commented Apr 26, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #85422 to release/7.0-staging

Handle NT_SIGINFO parameters on macOS for hardware-signal based exceptions.

/cc @hoyosjs

Customer Impact

This was a regression w.r.t 7.0.4 and 6.0.15. The regression caused no dumps or crash reports to be generated for crashes on hardware exceptions.

Testing

Testing in automation to be added out of band. Reported scenarios validated manually.

Risk

Low risk - linux uses the same parsing logic, and the values don't get used if not needed (macOS doesn't try to use the values).

Author:hoyosjs
Assignees:-
Labels:

area-Diagnostics-coreclr

Milestone:-

@ghostghost assigned hoyosjsApr 26, 2023
@build-analysisbuild-analysisBot mentioned this pull request Apr 27, 2023
Closed
jeffschwMSFT
jeffschwMSFT approved these changes Apr 27, 2023
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 6.0.x

@jeffschwMSFTjeffschwMSFT added the Servicing-consider Issue for next servicing release review label Apr 27, 2023
@jeffschwMSFTjeffschwMSFT added this to the 6.0.x milestone Apr 27, 2023
@rbhandarbhanda modified the milestones: 6.0.x, 6.0.18Apr 27, 2023
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 27, 2023
@hoyosjshoyosjs mentioned this pull request Apr 27, 2023
Closed
@hoyosjs
hoyosjs merged commit b393a37 into dotnet:release/6.0-stagingApr 27, 2023
@hoyosjs
hoyosjs deleted the juhoyosa/fix-createdump-args-6 branch April 27, 2023 22:19
@ghostghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes
+1 more reviewer
@mikem8361mikem8361mikem8361 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hoyosjshoyosjs

Labels

area-Diagnostics-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@hoyosjs@jeffschwMSFT@mikem8361@rbhanda