') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [Mono][RISC-V] emit mul inst instead of emulated mul by Xinlong-Wu · Pull Request #85445 · dotnet/runtime · GitHub
Skip to content

[Mono][RISC-V] emit mul inst instead of emulated mul - #85445

Merged
vargaz merged 23 commits into
dotnet:mainfrom
Xinlong-Wu:pr-Apr
Jul 8, 2023
Merged

[Mono][RISC-V] emit mul inst instead of emulated mul#85445
vargaz merged 23 commits into
dotnet:mainfrom
Xinlong-Wu:pr-Apr

Conversation

@Xinlong-Wu

@Xinlong-WuXinlong-Wu commented Apr 27, 2023

Copy link
Copy Markdown
Contributor
  • emit mul inst instead of emulated mul
  • try handle exceptions
  • emit inst idiv
  • process ArgOnStack arg at prologue
  • fix logic emit_imm

Xinlong-Wuand others added 21 commits April 8, 2023 13:44
@ghostghost added area-VM-meta-mono community-contribution Indicates that the PR has been added by a community member labels Apr 27, 2023
@Xinlong-WuXinlong-Wu mentioned this pull request Apr 27, 2023
Merged
@Xinlong-Wu

Xinlong-Wu commented Apr 27, 2023

Copy link
Copy Markdown
ContributorAuthor

btw, what should I do if I want to set up a CI for RISC-V Arch?

@am11am11 added the arch-riscv Related to the RISC-V architecture label Apr 27, 2023
@am11

am11 commented Apr 27, 2023

Copy link
Copy Markdown
Member

btw, what should I do if I want to set up a CI for RISC-V Arch?

Wait for #85443 😉

vargaz
vargaz reviewed Apr 27, 2023
View reviewed changes
Comment threadsrc/mono/mono/metadata/jit-icall-reg.h
@am11

am11 commented Apr 27, 2023

Copy link
Copy Markdown
Member

@Xinlong-Wu, with this PR, helloworld app works using dotnet (tested #84470 (comment)). 👍

I then tested this sample: https://github.com/dotnet/samples/tree/7b5da1b14bb3efc24d97e104ddbe5d3bb88f8cbc/csharp/getting-started/console-webapiclient, it throws from lowering:

$ /artifacts/bin/testhost/net8.0-linux-Debug-riscv64/dotnet bin/Release/net8.0/console-webapiclient.dll
unable to lowering following IR: long_mul_imm R45 <- R42
* Assertion: should not be reached at /runtime/src/mono/mono/mini/mini-riscv.c:2709

(aside: maybe reword unable to lowering following IR message as unable to lower the following IR)

This was referenced Apr 27, 2023
Closed
Closed
Closed
Closed
Closed
@Xinlong-Wu

Xinlong-Wu commented May 4, 2023

Copy link
Copy Markdown
ContributorAuthor

@Xinlong-Wu, with this PR, helloworld app works using dotnet (tested #84470 (comment)). 👍

I then tested this sample: https://github.com/dotnet/samples/tree/7b5da1b14bb3efc24d97e104ddbe5d3bb88f8cbc/csharp/getting-started/console-webapiclient, it throws from lowering:

$ /artifacts/bin/testhost/net8.0-linux-Debug-riscv64/dotnet bin/Release/net8.0/console-webapiclient.dll
unable to lowering following IR: long_mul_imm R45 <- R42
* Assertion: should not be reached at /runtime/src/mono/mono/mini/mini-riscv.c:2709

(aside: maybe reword unable to lowering following IR message as unable to lower the following IR)

yeah, cuz the port of Mono was not been completed. I think the IR long_mul_imm will be lowered in next pr

@build-analysisbuild-analysisBot mentioned this pull request May 4, 2023
Closed
@Xinlong-Wu

Xinlong-Wu commented Jul 8, 2023

Copy link
Copy Markdown
ContributorAuthor

ping, can this pr been merged?

@vargaz
vargaz merged commit 045b526 into dotnet:mainJul 8, 2023
@ghostghost locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageekAwaiting requested review from lambdageek
@thaystgthaystgAwaiting requested review from thaystg
1 more reviewer
@vargazvargazvargaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-riscvRelated to the RISC-V architecturearea-VM-meta-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Xinlong-Wu@am11@vargaz