Skip to content

Intrinsify Unsafe.Read/Write/Copy, handle struct BitCast - #85562

Merged
EgorBo merged 64 commits into
dotnet:mainfrom
MichalPetryka:bitcast-indir
Jul 23, 2023
Merged

Intrinsify Unsafe.Read/Write/Copy, handle struct BitCast#85562
EgorBo merged 64 commits into
dotnet:mainfrom
MichalPetryka:bitcast-indir

Conversation

@MichalPetryka

@MichalPetrykaMichalPetryka commented Apr 29, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements Unsafe.Read/Write/Copy (and the unaligned versions) as JIT intrinsics.

Fixes bugs with small type params not being correctly extended in bitcast.

Handles structs in Unsafe.BitCast via intrinsic.

Contributes to #69220.
Fixes#55357.

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 29, 2023
@ghost

ghost commented Apr 29, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements Unsafe.Read/Write (and the unaligned versions) as JIT intrinsics.

Handles structs in Unsafe.BitCast via intrinsic.

Contributes to #69220.

Author:MichalPetryka
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@MichalPetryka
MichalPetryka marked this pull request as ready for review April 30, 2023 18:35
SingleAccretion
SingleAccretion reviewed Apr 30, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
Comment threadsrc/coreclr/jit/importercalls.cpp Outdated
@MichalPetrykaMichalPetryka mentioned this pull request May 1, 2023
Closed
@MichalPetryka

MichalPetryka commented May 3, 2023

Copy link
Copy Markdown
ContributorAuthor

I'll be unable to respond to reviews for a few weeks, I've asked @thatbakamono to apply any feedback though.

@build-analysisbuild-analysisBot mentioned this pull request May 3, 2023
Closed
This was referenced Jul 14, 2023
Closed
Closed
@MichalPetrykaMichalPetryka mentioned this pull request Jul 16, 2023
Closed
@EgorBo

EgorBo commented Jul 16, 2023

Copy link
Copy Markdown
Member

/azp run runtime-coreclr outerloop, runtime-extra-platforms, runtime-coreclr pgostress

@azure-pipelines

azure-pipelinesBot commented Jul 16, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 85562 in repo dotnet/runtime

@EgorBo

EgorBo commented Jul 16, 2023

Copy link
Copy Markdown
Member

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 16, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 85562 in repo dotnet/runtime

@EgorBo

EgorBo commented Jul 16, 2023

Copy link
Copy Markdown
Member

/azp run runtime-coreclr jitstress

@azure-pipelines

azure-pipelinesBot commented Jul 16, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jul 17, 2023
Closed
This was referenced Jul 18, 2023
Closed
Closed
Closed
@EgorBo

EgorBo commented Jul 22, 2023

Copy link
Copy Markdown
Member

Can you please rebase it - CI should be better now

@MichalPetryka

MichalPetryka commented Jul 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@MihuBot

@MihuBotMihuBot mentioned this pull request Jul 22, 2023
Open
@EgorBo
EgorBo merged commit 8d2535d into dotnet:mainJul 23, 2023
@EgorBo

EgorBo commented Jul 23, 2023

Copy link
Copy Markdown
Member

Thanks!

@tannergoodingtannergooding mentioned this pull request Jul 23, 2023
Open
@MichalPetrykaMichalPetryka mentioned this pull request Jul 23, 2023
Closed
@radicalradical mentioned this pull request Jul 24, 2023
Closed
@EgorBoEgorBo mentioned this pull request Jul 27, 2023
Closed
@cincuranetcincuranet mentioned this pull request Aug 1, 2023
Closed
@AndyAyersMS

AndyAyersMS commented Aug 1, 2023

Copy link
Copy Markdown
Member

Improvments:

@AndyAyersMS

AndyAyersMS commented Aug 1, 2023

Copy link
Copy Markdown
Member

Possible regressions:

@ghostghost locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
+1 more reviewer
@SingleAccretionSingleAccretionSingleAccretion left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@EgorBoEgorBo

@MichalPetrykaMichalPetryka

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsafe.As resulting in lots of unnecessary moves.

5 participants

@MichalPetryka@JulieLeeMSFT@EgorBo@AndyAyersMS@SingleAccretion