') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ComWrappers test that allocate object can't inline by AaronRobinsonMSFT · Pull Request #85583 · dotnet/runtime · GitHub
Skip to content

ComWrappers test that allocate object can't inline#85583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 2 commits into from
May 2, 2023
Merged

ComWrappers test that allocate object can't inline #85583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e496d45
ComWrappers test that allocate object can't inline
AaronRobinsonMSFT May 1, 2023
9083210
Update test name and comments
AaronRobinsonMSFT May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions src/tests/Interop/COM/ComWrappers/API/Program.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -123,6 +123,7 @@ static void ForceGC()
}
}

[MethodImpl(MethodImplOptions.NoInlining)]
static void ValidateComInterfaceCreation()
{
Console.WriteLine($"Running {nameof(ValidateComInterfaceCreation)}...");
Expand DownExpand Up@@ -156,6 +157,7 @@ static void ValidateComInterfaceCreation()
Assert.Equal(0, count);
}

[MethodImpl(MethodImplOptions.NoInlining)]
static void ValidateComInterfaceCreationRoundTrip()
{
Console.WriteLine($"Running {nameof(ValidateComInterfaceCreationRoundTrip)}...");
Expand DownExpand Up@@ -212,6 +214,7 @@ static IntPtr CreateObjectAndGetComInterface()
// Just because one use of a COM interface returned from GetOrCreateComInterfaceForObject
// hits zero ref count does not mean future calls to GetOrCreateComInterfaceForObject
// should return an unusable object.
[MethodImpl(MethodImplOptions.NoInlining)]
static void ValidateCreatingAComInterfaceForObjectAfterTheFirstIsFree()
{
Console.WriteLine($"Running {nameof(ValidateCreatingAComInterfaceForObjectAfterTheFirstIsFree)}...");
Expand DownExpand Up@@ -247,6 +250,7 @@ unsafe static void CallSetValue(TestComWrappers wrappers, Test testInstance, int
}
}

[MethodImpl(MethodImplOptions.NoInlining)]
static void ValidateFallbackQueryInterface()
{
Console.WriteLine($"Running {nameof(ValidateFallbackQueryInterface)}...");
Expand DownExpand Up@@ -300,36 +304,42 @@ static void ValidateCreateObjectCachingScenario()
Assert.NotEqual(trackerObj1, trackerObj3);
}

// Make sure that if one wrapper is GCed, another can be created.
static void ValidateCreateObjectGcBehavior()
// Verify that if a GC nulls the contents of a weak GCHandle but has not yet
// run finializers to remove that GCHandle from the cache, the state of the system is valid.
static void ValidateCreateObjectWeakHandleCacheCleanUp()
{
Console.WriteLine($"Running {nameof(ValidateCreateObjectCachingScenario)}...");
Console.WriteLine($"Running {nameof(ValidateCreateObjectWeakHandleCacheCleanUp)}...");

var cw = new TestComWrappers();

// Get an object from a tracker runtime.
IntPtr trackerObjRaw = MockReferenceTrackerRuntime.CreateTrackerObject();

// Create the first native object wrapper and run the GC.
CreateObject();
CreateObject(cw, trackerObjRaw);

// Only attempt to run the GC, don't wait for the finalizer. We do this
// because of the multiple phase clean-up for ComWrappers caches.
// See weak GC handles in the NativeAOT scenario.
GC.Collect();
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

// Try to create another wrapper for the same object. The above GC
// may have collected parts of the ComWrapper cache, but this should
// still work.
CreateObject();
// may have collected parts of the ComWrapper cache, but not fully
// cleared the contents of the cache.
CreateObject(cw, trackerObjRaw);
ForceGC();

Marshal.Release(trackerObjRaw);

[MethodImpl(MethodImplOptions.NoInlining)]
void CreateObject()
static void CreateObject(ComWrappers cw, IntPtr trackerObj)
{
var obj = (ITrackerObjectWrapper)cw.GetOrCreateObjectForComInstance(trackerObjRaw, CreateObjectFlags.None);
var obj = (ITrackerObjectWrapper)cw.GetOrCreateObjectForComInstance(trackerObj, CreateObjectFlags.None);
Assert.NotNull(obj);
}
}

[MethodImpl(MethodImplOptions.NoInlining)]
static void ValidateMappingAPIs()
{
Console.WriteLine($"Running {nameof(ValidateMappingAPIs)}...");
Expand DownExpand Up@@ -383,6 +393,7 @@ static void ValidateMappingAPIs()
Marshal.Release(unmanagedObjIUnknown);
}

[MethodImpl(MethodImplOptions.NoInlining)]
static void ValidateWrappersInstanceIsolation()
{
Console.WriteLine($"Running {nameof(ValidateWrappersInstanceIsolation)}...");
Expand DownExpand Up@@ -808,7 +819,7 @@ static int Main()
ValidateCreatingAComInterfaceForObjectAfterTheFirstIsFree();
ValidateFallbackQueryInterface();
ValidateCreateObjectCachingScenario();
ValidateCreateObjectGcBehavior();
ValidateCreateObjectWeakHandleCacheCleanUp();
ValidateMappingAPIs();
ValidateWrappersInstanceIsolation();
ValidatePrecreatedExternalWrapper();
Expand Down