[mono][aot] Enabling AOT wrappers for virtual delegates by LeVladIonescu · Pull Request #85643 · dotnet/runtime

LeVladIonescu · 2023-05-02T11:54:56Z

Adding AOT wrappers for delegate invoke virtual.
Contributes to #83329.

Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu · 2023-05-02T11:55:51Z

 	MonoJumpInfoToken *ji;
 	guint8 *p = buf;

+	printf("NAME = %s\n", method->name);


unrelated change...only for debug reasons

Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu · 2023-05-11T14:11:14Z

Ready to review / merge.
Library tests build failures from CI are related.

LeVladIonescu · 2023-05-12T11:40:23Z

/azp run runtime

azure-pipelines · 2023-05-12T11:40:50Z

Azure Pipelines successfully started running 1 pipeline(s).

SamMonoRT · 2023-05-16T12:17:55Z

@LeVladIonescu - as part of this PR consider enabling any disabled tests fixed by the changes.

LeVladIonescu · 2023-05-16T12:23:39Z

@SamMonoRT will check

kotlarmilos · 2023-05-16T12:44:10Z

+ shared_context = mono_class_get_generic_container (method->klass)->context;
+ inst = shared_context.class_inst;
+
+ args = g_new0 (MonoType*, inst->type_argc);


Is the memory being deallocated correctly?

No, it is not. I would suggest deallocating it after
runtime/src/mono/mono/metadata/metadata.c
Line 3399 in 175dae9
memcpy (ginst->type_argv, type_argv, type_argc*sizeof (MonoType*));
^ @vargaz

I can be freed, but the aot compiler is already leaking memory in a number of places, so its not that important.

…d indentation Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu · 2023-05-18T10:55:21Z

Current failures are known and seem unrelated:

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
IOException running NuGet-Migrations during tests in dotnet CLI first run #80619

LeVladIonescu · 2023-05-18T10:57:49Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-05-18T10:58:09Z

Azure Pipelines successfully started running 1 pipeline(s).

LeVladIonescu · 2023-05-18T15:40:24Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-05-18T15:40:38Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu · 2023-05-18T22:27:37Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-05-18T22:27:48Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu · 2023-05-21T12:51:49Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-05-21T12:52:05Z

Azure Pipelines successfully started running 1 pipeline(s).

LeVladIonescu · 2023-05-22T08:00:29Z

Remaining failures are known and unrelated.

Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

Vlad - Alexandru Ionescu added 5 commits April 26, 2023 20:31

try to add virt delegates
33604b1

Added encode and decode of klass for DELEGATE_VIRTUAL subtype
e0d201d
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

Changed how construction of callvirt delegate is done
6b6dae9
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

Encode class only for delegate_invoke_virtual subtype
c98a748
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

Added condition for encoding wrapper subtype
0dbe14f

LeVladIonescu added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 2, 2023

LeVladIonescu requested review from SamMonoRT, lambdageek, thaystg and vargaz as code owners May 2, 2023 11:54

ghost assigned LeVladIonescu May 2, 2023

ghost added the area-Codegen-AOT-mono label May 2, 2023

LeVladIonescu commented May 2, 2023
View reviewed changes

Repro issue with iOS HelloiOS
030c8af

LeVladIonescu requested a review from marek-safar as a code owner May 4, 2023 12:52

build-analysisBot mentioned this pull request May 4, 2023
[wasm] Wasm.Build.Tests - blazor run tests failing #85769
Closed

vargaz reviewed May 9, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/aot-compiler.c

vargaz reviewed May 9, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/aot-runtime.c

Inst generic types for delegates
01231ce
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu changed the title ~~[DRAFT] Enabling AOT wrappers for virtual delegates~~[mono][aot] Enabling AOT wrappers for virtual delegatesMay 10, 2023

LeVladIonescu removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 10, 2023

build-analysisBot mentioned this pull request May 10, 2023
Roslyn source generator crash on mono/linux/arm64 #81123
Closed

LeVladIonescuand others added 3 commits May 11, 2023 10:05

Merge branch 'dotnet:main' into AOT_delegates
dc5ae4b

Reverted HelloiOS sample app changes
1b80a47
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

Merge branch 'dotnet:main' into AOT_delegates
534c69f

Merge branch 'dotnet:main' into AOT_delegates
f791de0

build-analysisBot mentioned this pull request May 12, 2023
[browser] Top-level await promise never resolved #86037
Closed

runfoappBot mentioned this pull request May 15, 2023
Infra improvements for Helix #68176
Closed

kotlarmilos reviewed May 16, 2023
View reviewed changes

Comment threadsrc/mono/mono/metadata/metadata.c Outdated

kotlarmilos reviewed May 16, 2023
View reviewed changes

Moved signature change to use generic version of the wrapper and fixe…
3658fbc
…d indentation Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

This was referenced May 18, 2023
Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637
Closed
CI build failure: Bash exited with code '1' failure - Could NOT find ZLIB #86324
Closed

Merge branch 'dotnet:main' into AOT_delegates
350bf94

LeVladIonescuand others added 2 commits May 19, 2023 00:26

Merge branch 'dotnet:main' into AOT_delegates
9f4788c

Deallocate args
26bf6bf
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

Added check for primitives
3e4c73d
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

This was referenced May 21, 2023
[mono][aot] Loader tests failing on CI with Mono LLVM FullAOT #86327
Closed
Build ios-arm64 Release AllSubsets_Mono failures dotnet/arcade#13625
Closed

Remove commented line
d44a7ae
Signed-off-by: Vlad - Alexandru Ionescu <vlad-alexandruionescu@Vlads-MacBook-Pro-5.local>

LeVladIonescu merged commit e91db04 into dotnet:mainMay 22, 2023

LeVladIonescu deleted the AOT_delegates branch May 22, 2023 10:35

This was referenced May 22, 2023
[mono] Change bound delegates dependency of bound_method + delegate_type to use just delegate_type #83329
Closed
[mono][AOT] Enabled tests which fail to JIT compile during AOT #86581
Merged

ghost locked as resolved and limited conversation to collaborators Jun 21, 2023

Uh oh!

Conversation

LeVladIonescu commented May 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LeVladIonescuMay 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

LeVladIonescu commented May 11, 2023

Uh oh!

LeVladIonescu commented May 12, 2023

Uh oh!

azure-pipelinesBot commented May 12, 2023

Uh oh!

SamMonoRT commented May 16, 2023

Uh oh!

LeVladIonescu commented May 16, 2023

Uh oh!

Uh oh!

kotlarmilosMay 16, 2023

Choose a reason for hiding this comment

Uh oh!

LeVladIonescuMay 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vargazMay 17, 2023

Choose a reason for hiding this comment

Uh oh!

LeVladIonescu commented May 18, 2023

Uh oh!

LeVladIonescu commented May 18, 2023

Uh oh!

azure-pipelinesBot commented May 18, 2023

Uh oh!

LeVladIonescu commented May 18, 2023

Uh oh!

azure-pipelinesBot commented May 18, 2023

Uh oh!

LeVladIonescu commented May 18, 2023

Uh oh!

azure-pipelinesBot commented May 18, 2023

Uh oh!

LeVladIonescu commented May 21, 2023

Uh oh!

azure-pipelinesBot commented May 21, 2023

Uh oh!

LeVladIonescu commented May 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LeVladIonescu commented May 2, 2023•
edited
Loading

LeVladIonescuMay 16, 2023•
edited
Loading