Uh oh!
There was an error while loading. Please reload this page.
Convert JIT/opt to a merged test group - #85850
Conversation
…nternal parameter types
ghost
commented
May 5, 2023
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsSee https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way.
|
ghost
commented
May 5, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsSee https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way.
|
markples
commented
May 6, 2023
/azp run runtime-coreclr outerloop, runtime-extra-platforms, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| continue; | ||
| } | ||
| var argsAsCode = ImmutableArray.CreateRange(args.Select(a => a.ToCSharpString())); | ||
| var argsAsCode = ImmutableArray.CreateRange(args.Select(a => a.ToCSharpString() + (a.Type!.SpecialType == SpecialType.System_Single ? "F" : ""))); |
There was a problem hiding this comment.
Without this change, a float constant in [InlineData] leads to a build failure when trying to pass a double constant for a float parameter. This isn't a great or complete solution, but I couldn't find a good public entry point in Roslyn to do this correctly, and float cases do not work at all currently.
markples
commented
May 12, 2023
This is ready @trylek @dotnet/jit-contrib |
See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way and paying more attention to manual changes.
In this group, I was a bit more aggressive in converting individual tests in [Fact]s and [Theory]s when needing to make manual changes. This required a change to the wrapper generator (see my comment there).