[mono][aot] Deduplicate runtime invoke wrappers on iOS

[kotlarmilos]

This PR deduplicates runtime invoke wrappers on iOS, which aligns WASM and iOS implementations. Approximately 30 runtime invoke wrappers have been deduplicated, resulting in minimal size savings. According to the HelloiOS measurements, the reduction amounts to about 2kb or 0.01%, which could be within the margin of statistical error.

Such change had an issue with the CI in #84304, even though the tests passed locally.

Fixes#83973

[kotlarmilos]

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[kotlarmilos]

The System.Runtime tests are failing randomly at different points on the ios-arm64 CI, but they are passing when run locally on a device and on the tvos-arm64 CI. Considering that we are still in the early preview stage, I suggest two possible options:

• Close the PR and don't consider deduplication of the runtime invoke wrappers. This means that the iOS implementation will remain inconsistent with the WASM implementation.
• Merge the PR and if the issue continues to occur on the CI, revert the PR.

/cc: @steveisok@SamMonoRT@vargaz

[kotlarmilos]

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[SamMonoRT]

The System.Runtime tests are failing randomly at different points on the ios-arm64 CI, but they are passing when run locally on a device and on the tvos-arm64 CI. Considering that we are still in the early preview stage, I suggest two possible options:

• Close the PR and don't consider deduplication of the runtime invoke wrappers. This means that the iOS implementation will remain inconsistent with the WASM implementation.
• Merge the PR and if the issue continues to occur on the CI, revert the PR.

/cc: @steveisok@SamMonoRT@vargaz

Are the random failures happening only as part of your PR, or have we seen those random failures outside your PR? If only in PR, I say try to add more logging and see if we can pinpoint any relevant fixes.

[kotlarmilos]

Are the random failures happening only as part of your PR, or have we seen those random failures outside your PR? If only in PR, I say try to add more logging and see if we can pinpoint any relevant fixes.

These failures are also present in other pipeline runs, always reporting the TCP failure. In this PR, the following pipelines fail, which could indicate that the issue could be with the tests scheduling or networking:

• runtime - ios-arm64
• ioslike - tvos-arm64
• extra-platforms - tvos-arm64 and ios-arm64

However, upon retrying the runs, the distribution of failures remains unchanged, which leads to a suspicion that the issue might be related. There are no other error logs indicating that the runtime can't find the runtime invoke wrappers.

[kotlarmilos]

Test retries indicate that the failures occur randomly. Based on the test logs, it is observed that the failures do not follow any pattern and can happen randomly during the test suite execution, without being tied to any particular test.

[kotlarmilos]

@akoeplinger@steveisok I think you could provide valuable feedback as you have encountered the TCP failure in the past.

[kotlarmilos]

I've merged this PR. If we encounter more frequent failures following the merge, I will revert the change.

/cc: @akoeplinger@steveisok

[kotlarmilos]

We have encountered more frequent failures following the merge, so I suggest we revert the change and try to reproduce the issue locally using the same version of macOS and iPhone as on the CI environment.

[steveisok]

Agreed, I think this change does have an impact on CI and needs reverted.