') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono][aot] Generate 'native-indirect' wrappers in full-aot mode. by vargaz · Pull Request #85923 · dotnet/runtime · GitHub
Skip to content

[mono][aot] Generate 'native-indirect' wrappers in full-aot mode. - #85923

Merged
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:native-indirect
May 9, 2023
Merged

[mono][aot] Generate 'native-indirect' wrappers in full-aot mode.#85923
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:native-indirect

Conversation

@vargaz

@vargazvargaz commented May 8, 2023

Copy link
Copy Markdown
Contributor

Fixes#80853.

@vargaz
vargaz removed the request for review from lambdageekMay 8, 2023 16:29
@ghostghost assigned vargazMay 8, 2023
@vargaz
vargaz requested a review from lambdageekMay 8, 2023 16:29
@vargaz
vargaz requested a review from thaystg as a code ownerMay 8, 2023 17:22
@Boxter187

Boxter187 commented May 8, 2023

Copy link
Copy Markdown

Fixes #80853.

Can't sing for my Firefox account with this hash tag number what do you think to get it right??

@vargaz

vargaz commented May 8, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented May 8, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

SamMonoRT
SamMonoRT reviewed May 8, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/aot-compiler.c Outdated
@SamMonoRT

SamMonoRT commented May 8, 2023

Copy link
Copy Markdown
Member

we should also run extraplatforms once initial validation is completed

cc @jandupej@kotlarmilos - please review the changes

@vargaz

vargaz commented May 8, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented May 8, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargazvargaz added the NO-REVIEW Experimental/testing PR, do NOT review it label May 8, 2023
This was referenced May 8, 2023
Closed
Closed
@vargazvargaz removed the NO-REVIEW Experimental/testing PR, do NOT review it label May 8, 2023
This was referenced May 8, 2023
Closed
Closed
kotlarmilos
kotlarmilos approved these changes May 9, 2023
View reviewed changes

@kotlarmiloskotlarmilos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment threadsrc/mono/mono/mini/method-to-ir.c
jandupej
jandupej approved these changes May 9, 2023
View reviewed changes

@jandupejjandupej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM.

@vargaz

vargaz commented May 9, 2023

Copy link
Copy Markdown
ContributorAuthor

Wasm failures are unrelated.

@vargaz
vargaz merged commit 209d681 into dotnet:mainMay 9, 2023
@vargaz
vargaz deleted the native-indirect branch May 9, 2023 21:30
@radicalradical mentioned this pull request May 10, 2023
Closed
@steveisoksteveisok mentioned this pull request May 18, 2023
Closed
@SamMonoRT

SamMonoRT commented May 30, 2023

Copy link
Copy Markdown
Member

@kotlarmilos@vargaz - we should start the backport to 7 for this issue.

@kotlarmilos

kotlarmilos commented May 31, 2023

Copy link
Copy Markdown
Member

/backport to release/7.0-staging

@github-actions

github-actionsBot commented May 31, 2023

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5129756689

@github-actionsgithub-actionsBot mentioned this pull request May 31, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SamMonoRTSamMonoRTSamMonoRT left review comments
@kotlarmiloskotlarmiloskotlarmilos approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
+1 more reviewer
@jandupejjandupejjandupej approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vargazvargaz

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Starting App on iOS fails with System.ExecutingEngineException

5 participants

@vargaz@Boxter187@SamMonoRT@kotlarmilos@jandupej