Skip to content

JIT/EE interface cleanup - #85975

Merged
jkotas merged 12 commits into
dotnet:mainfrom
jkotas:jitee-cleanup
May 10, 2023
Merged

JIT/EE interface cleanup#85975
jkotas merged 12 commits into
dotnet:mainfrom
jkotas:jitee-cleanup

Conversation

@jkotas

@jkotasjkotas commented May 9, 2023

Copy link
Copy Markdown
Member
  • Delete methods, fields and flags related to verification that is no longer supported
  • Delete flags for old x86 models that are no longer needed given SSE2 is our baseline

@jkotas
JIT/EE interface cleanup
5704c92
- Delete methods, fields and flags related to verification that is no longer supported
- Delete flags for old x86 models that are no longer needed given SSE2
is our baseline
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 9, 2023
@ghostghost assigned jkotasMay 9, 2023
@ghost

ghost commented May 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Delete methods, fields and flags related to verification that is no longer supported
  • Delete flags for old x86 models that are no longer needed given SSE2 is our baseline
Author:jkotas
Assignees:jkotas
Labels:

area-CodeGen-coreclr

Milestone:-

tannergooding
tannergooding reviewed May 9, 2023
View reviewed changes
Comment threadsrc/coreclr/vm/codeman.cpp
tannergooding
tannergooding reviewed May 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/codegencommon.cpp Outdated
@jkotas
jkotas requested a review from EgorBoMay 9, 2023 19:21
@jkotas

jkotas commented May 9, 2023

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib This is ready for review

tannergooding
tannergooding reviewed May 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/codegencommon.cpp
tannergooding
tannergooding reviewed May 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.cpp
jakobbotsch
jakobbotsch reviewed May 9, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/compiler.h
@build-analysisbuild-analysisBot mentioned this pull request May 10, 2023
Closed
@jkotas
jkotas merged commit 6971065 into dotnet:mainMay 10, 2023
@jkotas
jkotas deleted the jitee-cleanup branch May 10, 2023 01:47
@jakobbotschjakobbotsch mentioned this pull request May 10, 2023
Merged
@BruceForstallBruceForstall mentioned this pull request May 11, 2023
Closed
@markplesmarkples mentioned this pull request May 19, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch left review comments
@EgorBoEgorBoEgorBo approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+1 more reviewer
@SingleAccretionSingleAccretionSingleAccretion left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jkotasjkotas

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkotas@EgorBo@jakobbotsch@tannergooding@SingleAccretion