') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/6.0] Fix HTTTP/2 header decoder buffer allocation by ManickaP · Pull Request #85976 · dotnet/runtime · GitHub
Skip to content

[release/6.0] Fix HTTTP/2 header decoder buffer allocation - #85976

Merged
MihaZupan merged 1 commit into
dotnet:release/6.0-stagingfrom
ManickaP:release/6.0-staging
May 15, 2023
Merged

[release/6.0] Fix HTTTP/2 header decoder buffer allocation#85976
MihaZupan merged 1 commit into
dotnet:release/6.0-stagingfrom
ManickaP:release/6.0-staging

Conversation

@ManickaP

@ManickaPManickaP commented May 9, 2023

Copy link
Copy Markdown
Member

Fixes#78516

Backports #78862

Customer impact

Reliability problem in HTTP/2 (HPack), where some requests/responses with large headers (4KB+) that should be accepted might end up throwing exception.

This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET.

Testing

Added tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI.

Risk

Low, as this affects only (rare) case of 4KB+ headers data buffers in HTTP/2 (HPack).

@BrunoBlanes@ManickaP
Fix HTTP3 header decoder buffer allocation (dotnet#78862)
baa1662
* Add test for literal field without name reference
* Fix header name buffer allocation
* Add more tests
* Unified QPackDecoderTest test files
* Fix variable name
* Fixed HPackDecoder and ported QPack tests
* Feedback
---------
Co-authored-by: ManickaP <mapichov@microsoft.com>
@ghostghost assigned ManickaPMay 9, 2023
@ghost

ghost commented May 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78516

Backports #78862

Customer impact

Reliability problem in HTTP/2 (HPack), where some requests/responses with large headers (4KB+) that should be accepted might end up throwing exception.

This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET.

Testing

Added tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI.

Risk

Low, as this affects only (rare) case of 4KB+ headers data buffers in HTTP/2 (HPack).

Author:ManickaP
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@ManickaPManickaP mentioned this pull request May 9, 2023
Closed
@ManickaPManickaP added the Servicing-approved Approved for servicing release label May 9, 2023
@ManickaP

ManickaP commented May 9, 2023•
edited by karelz
Loading

Copy link
Copy Markdown
MemberAuthor

From: #85341 (comment)

Approved by Tactics (@SteveMCarroll) on 4/27 via email. Marking as servicing-approved.

@ManickaP
ManickaP requested a review from MihaZupanMay 9, 2023 14:13
@build-analysisbuild-analysisBot mentioned this pull request May 9, 2023
Closed
@carlossanlopcarlossanlop mentioned this pull request May 15, 2023
Closed
@carlossanlop

carlossanlop commented May 15, 2023

Copy link
Copy Markdown
Contributor

@ManickaP@MihaZupan@karelz today is code complete for the June Release. Is this ready to merge?

  • Approved by Tactics.
  • Signed-off by area owner.
  • CI failures confirmed as unrelated.
  • Confirmed if OOB package changes are needed or not, and included them if they're needed.

@MihaZupan

MihaZupan commented May 15, 2023

Copy link
Copy Markdown
Member

@carlossanlop Yes, these should be ready to merge.
This and 7.0 PR (#85977) have no OOB package changes.
Test failures on both PRs are only in runtime-staging. @ManickaP investigated test failures on previous PRs (identical but against release/6.0 instead of staging) as unrelated: #85341 (comment).

@MihaZupan
MihaZupan merged commit c93a40e into dotnet:release/6.0-stagingMay 15, 2023
@ManickaP
ManickaP deleted the release/6.0-staging branch May 16, 2023 11:54
@karelzkarelz added this to the 6.0.x milestone May 27, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jun 26, 2023
@karelzkarelz modified the milestones: 6.0.x, 6.0.18Jul 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MihaZupanMihaZupanMihaZupan approved these changes

Assignees

@ManickaPManickaP

Labels

area-System.Net.HttpServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.18

Development

Successfully merging this pull request may close these issues.

5 participants

@ManickaP@carlossanlop@MihaZupan@karelz@BrunoBlanes