Skip to content

Add ArgumentException.ThrowIfNullOrWhiteSpace - #86007

Merged
stephentoub merged 2 commits into
dotnet:mainfrom
stephentoub:throwifwhitespace
May 10, 2023
Merged

Add ArgumentException.ThrowIfNullOrWhiteSpace#86007
stephentoub merged 2 commits into
dotnet:mainfrom
stephentoub:throwifwhitespace

Conversation

@stephentoub

@stephentoubstephentoub commented May 9, 2023

Copy link
Copy Markdown
Member

Fixes#77749

@ghost

ghost commented May 9, 2023

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost assigned stephentoubMay 9, 2023
@ghost

ghost commented May 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #77749

Author:stephentoub
Assignees:-
Labels:

area-System.Net.Http, new-api-needs-documentation

Milestone:-

Sergio0694
Sergio0694 reviewed May 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/ArgumentException.cs Outdated
MihaZupan
MihaZupan approved these changes May 9, 2023
View reviewed changes
Comment threadsrc/libraries/Common/src/System/Net/WebSockets/WebSocketValidate.cs Outdated
This was referenced May 9, 2023
Closed
Closed
Closed
danmoseley
danmoseley reviewed May 10, 2023
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/Resources/Strings.resx
@build-analysisbuild-analysisBot mentioned this pull request May 10, 2023
Closed
@stephentoub
stephentoub merged commit 22c1337 into dotnet:mainMay 10, 2023
@stephentoub
stephentoub deleted the throwifwhitespace branch May 10, 2023 20:49
This was referenced May 10, 2023
Closed
Closed
@danmoseleydanmoseley mentioned this pull request May 10, 2023
Closed
@wcontayonwcontayon mentioned this pull request May 24, 2023
Closed
4 tasks
@karelzkarelz added this to the 8.0.0 milestone May 27, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo left review comments
@MihaZupanMihaZupanMihaZupan approved these changes
+2 more reviewers
@danmoseleydanmoseleydanmoseley left review comments
@Sergio0694Sergio0694Sergio0694 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoubstephentoub

Labels

area-System.Net.Httpnew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: ArgumentException helper methods

6 participants

@stephentoub@EgorBo@danmoseley@Sergio0694@MihaZupan@karelz