Skip to content

Add tests for RUC warnings on override methods - #86015

Merged
vitek-karas merged 4 commits into
dotnet:mainfrom
vitek-karas:TestWarnDAMOverride
May 12, 2023
Merged

Add tests for RUC warnings on override methods#86015
vitek-karas merged 4 commits into
dotnet:mainfrom
vitek-karas:TestWarnDAMOverride

Conversation

@vitek-karas

@vitek-karasvitek-karas commented May 9, 2023

Copy link
Copy Markdown
Member

These are tests for bug #86008.

I also restructured the test file into nested classes some more as it's easier to navigate this way.

Also adds a test for #86032.

@vitek-karasvitek-karas added test-enhancement Improvements of test source code area-Tools-ILLink .NET linker development as well as trimming analyzers labels May 9, 2023
@vitek-karasvitek-karas added this to the 8.0.0 milestone May 9, 2023
@vitek-karas
vitek-karas requested a review from sbomerMay 9, 2023 20:31
@vitek-karasvitek-karas self-assigned this May 9, 2023
@ghostghost added the linkable-framework Issues associated with delivering a linker friendly framework label May 9, 2023
@ghost

ghost commented May 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

These are tests for bug #86008.

I also restructured the test file into nested classes some more as it's easier to navigate this way.

Author:vitek-karas
Assignees:vitek-karas
Labels:

test-enhancement, area-Tools-ILLink

Milestone:8.0.0

@ghost

ghost commented May 9, 2023

Copy link
Copy Markdown

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

These are tests for bug #86008.

I also restructured the test file into nested classes some more as it's easier to navigate this way.

Author:vitek-karas
Assignees:vitek-karas
Labels:

test-enhancement, linkable-framework, area-Tools-ILLink

Milestone:8.0.0

@vitek-karas

Copy link
Copy Markdown
MemberAuthor

All CI failures are unrelated

@sbomersbomer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitek-karas
vitek-karas merged commit 5fabb48 into dotnet:mainMay 12, 2023
@vitek-karas
vitek-karas deleted the TestWarnDAMOverride branch May 12, 2023 20:31
@ghostghost locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzerslinkable-frameworkIssues associated with delivering a linker friendly frameworktest-enhancementImprovements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vitek-karas@sbomer