') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [mono][aot] Fix an assert. by vargaz · Pull Request #86054 · dotnet/runtime · GitHub
Skip to content

[mono][aot] Fix an assert. - #86054

Merged
lewing merged 1 commit into
dotnet:mainfrom
vargaz:fix-aot-assert2
May 10, 2023
Merged

[mono][aot] Fix an assert.#86054
lewing merged 1 commit into
dotnet:mainfrom
vargaz:fix-aot-assert2

Conversation

@vargaz

@vargazvargaz commented May 10, 2023

Copy link
Copy Markdown
Contributor

Fixes#86052.

@ghostghost assigned vargazMay 10, 2023
@vargaz
vargaz requested a review from radicalMay 10, 2023 16:22
@radical

radical commented May 10, 2023

Copy link
Copy Markdown
Member

/azp run runtime-wasm-perf

@azure-pipelines

azure-pipelinesBot commented May 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented May 10, 2023

Copy link
Copy Markdown
Member

WBT failing with:

 [System.Private.CoreLib.dll] Exec (with response file contents expanded) in /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in: MONO_PATH=/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in:/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/8.0.0-ci/runtimes/browser-wasm/native/:/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/8.0.0-ci/runtimes/browser-wasm//lib/net8.0 MONO_ENV_OPTIONS= /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm/8.0.0-ci/Sdk/../tools/mono-aot-cross --wasm-exceptions --debug --llvm "--aot=no-opt,static,direct-icalls,deterministic,mattr=simd,dwarfdebug,llvm-path=/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Sdk.linux-x64/8.0.0-preview.5.23252.1/tools/bin/,static,dedup-skip,llvmonly,interp,asmonly,llvm-outfile=/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/System.Private.CoreLib.dll.bc.tmp" "System.Private.CoreLib.dll"
Precompiling failed for /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in/System.Private.CoreLib.dll with exit code 134. [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/blazorwasm_Debug_aot_3yecgsan.jot.csproj]
Mono Ahead of Time compiler - compiling assembly /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in/System.Private.CoreLib.dll [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/blazorwasm_Debug_aot_3yecgsan.jot.csproj]
* Assertion at /__w/1/s/src/mono/mono/mini/aot-compiler.c:10276, condition `info->subtype == WRAPPER_SUBTYPE_NONE || info->subtype == WRAPPER_SUBTYPE_PINVOKE' not met [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/blazorwasm_Debug_aot_3yecgsan.jot.csproj]

@vargaz

vargaz commented May 10, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-wasm-perf

@azure-pipelines

azure-pipelinesBot commented May 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented May 10, 2023

Copy link
Copy Markdown
Member

/azp run runtime-wasm-libtests

@azure-pipelines

azure-pipelinesBot commented May 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented May 10, 2023

Copy link
Copy Markdown
Member

Runtime-wasm-perf failures are unrelated.

@lewing
lewing merged commit 0b5f137 into dotnet:mainMay 10, 2023
@vargaz
vargaz deleted the fix-aot-assert2 branch May 11, 2023 00:17
@ghostghost locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT

Assignees

@vargazvargaz

Labels

area-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] AOT perf runs, and library tests are failing due to src/mono/mono/mini/aot-compiler.c:10110

3 participants

@vargaz@radical@lewing