Uh oh!
There was an error while loading. Please reload this page.
Hardcode the path to libclang from Mariner, not Clang 9 on CentOS 7 - #86096
Merged
directhex merged 3 commits intoMay 11, 2023
Merged
Conversation
ghost
commented
May 11, 2023
Tagging subscribers to this area: @hoyosjs Issue DetailsCloses: #85529
|
directhex
commented
May 11, 2023
ContributorAuthor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
This was referenced May 11, 2023
sbomer
reviewed
May 11, 2023
Uh oh!
There was an error while loading. Please reload this page.
sbomer
approved these changes
May 11, 2023
sbomer
left a comment
Member
There was a problem hiding this comment.
I don't have context to understand why the scenario needs to hard-code the path, but the fix LGTM.
jkoritzinsky
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #85529