Skip to content

[lib][tests] Globalization comparison tests cleanup - #86305

Closed
ilonatommy wants to merge 3 commits into
dotnet:mainfrom
ilonatommy:globalization-tests-cleanup
Closed

[lib][tests] Globalization comparison tests cleanup#86305
ilonatommy wants to merge 3 commits into
dotnet:mainfrom
ilonatommy:globalization-tests-cleanup

Conversation

@ilonatommy

@ilonatommyilonatommy commented May 16, 2023

Copy link
Copy Markdown
Member

Initiated by #85965 (comment).
In the original globalization comparison tests we used to have test cases with multiple comparison options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Initiated by #85965 (comment).
In the original globalization comparison tests we used to have comparison test cases with multiple options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.

Author:ilonatommy
Assignees:ilonatommy
Labels:

area-System.Globalization

Milestone:-

@ilonatommyilonatommy changed the title Cleanup.[lib][tests] Globalization comparison tests cleanupMay 16, 2023
@tarekghtarekgh added the arch-wasm WebAssembly architecture label May 16, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Initiated by #85965 (comment).
In the original globalization comparison tests we used to have test cases with multiple comparison options. Actually never all 3 declared options were relevant which obscured the test readibility. This PR reduces the number of options passed to minimum.

Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-System.Globalization

Milestone:-

@mkhamoyan

Copy link
Copy Markdown
Contributor

/azp run runtime-ioslike

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan

Copy link
Copy Markdown
Contributor

Looks good to me. Let's wait for tests to run on iOS.

@ilonatommy

Copy link
Copy Markdown
MemberAuthor

ios failures are unrelated

@mkhamoyan

Copy link
Copy Markdown
Contributor

@ilonatommy there is also supportedCmpOptions which looks like same property. As in my current PR #85965 I am touching a lot of lines after this PR got merged there will be need to check a lot of lines one by one. So my suggestion is either I can do these refactoring in my current PR, either let's do this after my PR got merged?

@ilonatommy

Copy link
Copy Markdown
MemberAuthor

So my suggestion is either I can do these refactoring in my current PR, either let's do this after my PR got merged?

If it won't be problematic then doing it in your PR is fine.

@mkhamoyan

Copy link
Copy Markdown
Contributor

Thanks, I will do then.

mkhamoyan added a commit that referenced this pull request May 17, 2023

@mdh1418mdh1418 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going in and finding the minimum options!

@ilonatommy

Copy link
Copy Markdown
MemberAuthor

This will get in with #85965. We checked that CI is passing with the changes but decided that it's less confusing for Meri to incorporate the changes directly in her PR.

mkhamoyan added a commit that referenced this pull request May 24, 2023
Implemented CompareStringNative for OSX platforms
Added changes done by @ilonatommy in #86305
@ghostghost locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Globalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@mkhamoyan@mdh1418@tarekgh