') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix deadlock in NativeRuntimeEventSourceTest by davmason · Pull Request #86370 · dotnet/runtime · GitHub
Skip to content

Fix deadlock in NativeRuntimeEventSourceTest - #86370

Merged
davmason merged 3 commits into
dotnet:mainfrom
davmason:testfix
May 18, 2023
Merged

Fix deadlock in NativeRuntimeEventSourceTest#86370
davmason merged 3 commits into
dotnet:mainfrom
davmason:testfix

Conversation

@davmason

@davmasondavmason commented May 17, 2023

Copy link
Copy Markdown
Contributor

Fixes#86233

@davmasondavmason added this to the 8.0.0 milestone May 17, 2023
@davmason
davmason requested review from a team and BruceForstallMay 17, 2023 07:04
@davmasondavmason self-assigned this May 17, 2023
@davmasondavmason mentioned this pull request May 17, 2023
Closed
noahfalk
noahfalk approved these changes May 17, 2023
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine. Given that this looks like a workaround, what meaning should I ascribe to the test failure? Is it a bug in the test, a bug in the product that we are choosing not to fix, a bug in the product that will be fixed later?

@BruceForstall

BruceForstall commented May 17, 2023

Copy link
Copy Markdown
Contributor

Build failed:

/__w/1/s/src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs(27,34): error CS0103: The name 'ArrayPool' does not exist in the current context [/__w/1/s/src/tests/tracing/runtimeeventsource/nativeruntimeeventsource.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs(27,34): error CS0103: The name 'ArrayPool' does not exist in the current context [/__w/1/s/src/tests/tracing/runtimeeventsource/nativeruntimeeventsource.csproj]
/__w/1/s/src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs(28,60): error CS1061: 'byte[]' does not contain a definition for 'Lenth' and no accessible extension method 'Lenth' accepting a first argument of type 'byte[]' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/tracing/runtimeeventsource/nativeruntimeeventsource.csproj] [/__w/1/s/src/tests/build.proj]
##[error]src/tests/tracing/runtimeeventsource/NativeRuntimeEventSourceTest.cs(28,60): error CS1061: 'byte[]' does not contain a definition for 'Lenth' and no accessible extension method 'Lenth' accepting a first argument of type 'byte[]' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/tracing/runtimeeventsource/nativeruntimeeventsource.csproj]

@davmason

davmason commented May 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Given that this looks like a workaround, what meaning should I ascribe to the test failure? Is it a bug in the test, a bug in the product that we are choosing not to fix, a bug in the product that will be fixed later?

It's a bug in the product, but I don't think customers are likely to hit it. There is a potential deadlock between shutting down EventPipeEventDispatcher and an EventListener if you create EventSources in your OnEventWritten callback. I don't think this is a common scenario, we are particularly vulnerable to it in the tests because they are short lived and only write an event or two, and touching framework code can cause EventSources like ArrayPoolEventSource to be lazy initted.

To my knowledge we haven't had customer reports, because their EventListeners are generally longer lived.

@noahfalk

noahfalk commented May 17, 2023•
edited
Loading

Copy link
Copy Markdown
Member

I'd suggest you add a comment to the test code saying that we believe a product issue exists here, but for now we are choosing not to fix it because we believe it doesn't impact any customers. Thanks David!

@davmason
davmason merged commit 4db4bb5 into dotnet:mainMay 18, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@noahfalknoahfalknoahfalk approved these changes
@BruceForstallBruceForstallAwaiting requested review from BruceForstall

Assignees

@davmasondavmason

Labels

area-Tracing-coreclr

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Test failure tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource.sh

3 participants

@davmason@BruceForstall@noahfalk