Skip to content

Haiku: Configuration support - #86391

Merged
jkotas merged 1 commit into
dotnet:mainfrom
trungnt2910:dev/trungnt2910/haiku-config
Oct 24, 2023
Merged

Haiku: Configuration support#86391
jkotas merged 1 commit into
dotnet:mainfrom
trungnt2910:dev/trungnt2910/haiku-config

Conversation

@trungnt2910

@trungnt2910trungnt2910 commented May 17, 2023

Copy link
Copy Markdown
Contributor

Added more support for configuration for Haiku cross-compile builds.

This commit adds recognition for Haiku as a supported platform in various build and configuration files.

For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the <ucontext.h> header. (According to the latest POSIX standard, ucontext_t should be defined in <signal.h>, while <ucontext.h> is no longer mandated). -ldl is also replaced with ${CMAKE_DL_LIBS} since Haiku does not have libdl.

Part of #55803.

@ghostghost added community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 17, 2023
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch 3 times, most recently from 8b9fb18 to af97252CompareMay 17, 2023 16:59
@vargaz

vargaz commented May 17, 2023

Copy link
Copy Markdown
Contributor

The mono changes look ok.

@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from af97252 to 79b7330CompareMay 17, 2023 17:29
@runfoapprunfoappBot mentioned this pull request May 17, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request May 17, 2023
Closed
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 79b7330 to 3b981e8CompareMay 18, 2023 00:31
@build-analysisbuild-analysisBot mentioned this pull request May 18, 2023
Closed
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 3b981e8 to 2c315d5CompareMay 26, 2023 13:37
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 2c315d5 to e8d4f3cCompareMay 28, 2023 12:35
This was referenced May 28, 2023
Closed
Closed
@danmoseleydanmoseley added area-Infrastructure-coreclr Only use for closed issues and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 1, 2023
@ghost

ghost commented Jun 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Added more support for configuration for Haiku cross-compile builds.

This commit adds recognition for Haiku as a supported platform in various build and configuration files.

For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the <ucontext.h> header. (According to the latest POSIX standard, ucontext_t should be defined in <signal.h>, while <ucontext.h> is no longer mandated). -ldl is also replaced with ${CMAKE_DL_LIBS} since Haiku does not have libdl.

Part of #55803.

Author:trungnt2910
Assignees:-
Labels:

area-Infrastructure-coreclr, community-contribution, os-haiku

Milestone:-

@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from e8d4f3c to 75f5797CompareJune 2, 2023 08:41
This was referenced Jun 2, 2023
Closed
Closed
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 75f5797 to 9195830CompareJune 5, 2023 04:03
@build-analysisbuild-analysisBot mentioned this pull request Jun 5, 2023
Closed
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 9195830 to 3012760CompareJune 7, 2023 12:00
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch 5 times, most recently from 91e7d16 to 98090daCompareJuly 31, 2023 06:55
@trungnt2910trungnt2910 mentioned this pull request Aug 20, 2023
Merged
ViktorHofer
ViktorHofer reviewed Sep 7, 2023
View reviewed changes
Comment threadsrc/libraries/System.Data.Odbc/src/System.Data.Odbc.csproj Outdated
@trungnt2910trungnt2910 mentioned this pull request Sep 8, 2023
Merged
@ViktorHoferViktorHofer mentioned this pull request Sep 18, 2023
Merged
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 98090da to 222bc8eCompareSeptember 24, 2023 01:14
am11
am11 reviewed Sep 24, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.NETCore.Platforms/src/runtime.json Outdated
am11
am11 approved these changes Sep 24, 2023
View reviewed changes

@am11am11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 222bc8e to 3698fb8CompareOctober 1, 2023 00:24
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from 3698fb8 to e5ba96eCompareOctober 22, 2023 01:00
@build-analysisbuild-analysisBot mentioned this pull request Oct 22, 2023
Closed
jkotas
jkotas reviewed Oct 22, 2023
View reviewed changes
Comment threadsrc/tests/Directory.Build.props Outdated
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from e5ba96e to a0efe97CompareOctober 23, 2023 01:54
jkotas
jkotas approved these changes Oct 23, 2023
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any concerns with getting this PR merged?

@build-analysisbuild-analysisBot mentioned this pull request Oct 23, 2023
Closed
ViktorHofer
ViktorHofer approved these changes Oct 23, 2023
View reviewed changes

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The libraries changes look good to me. I would like to change the four touched projects (Net.Http, Net.NetworkInformation, Net.Security and Serialization.Formatters) in the future so that we don't have to introduce new platform TFMs.

@jkotas

jkotas commented Oct 23, 2023

Copy link
Copy Markdown
Member

@trungnt2910 Could you please resolve the conflict?

@trungnt2910
Haiku: Configuration support
7338ea4
Added more support for configuration for Haiku cross-compile
builds.
@trungnt2910
trungnt2910force-pushed the dev/trungnt2910/haiku-config branch from a0efe97 to 7338ea4CompareOctober 24, 2023 00:48
@trungnt2910

trungnt2910 commented Oct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@trungnt2910 Could you please resolve the conflict?

Done.

This was referenced Oct 24, 2023
Closed
Closed
@jkotas

jkotas commented Oct 24, 2023

Copy link
Copy Markdown
Member

@trungnt2910 Thank you!

@jkotas
jkotas merged commit d775a3b into dotnet:mainOct 24, 2023
@trungnt2910trungnt2910 mentioned this pull request Oct 25, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dsplaisteddsplaisteddsplaisted left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT left review comments
@elinor-fungelinor-fungelinor-fung left review comments
@jkotasjkotasjkotas approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@marek-safarmarek-safarAwaiting requested review from marek-safar
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+2 more reviewers
@tmdstmdstmds left review comments
@am11am11am11 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issuescommunity-contributionIndicates that the PR has been added by a community memberos-haiku

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@trungnt2910@vargaz@jkotas@dsplaisted@tmds@akoeplinger@am11@ViktorHofer@AaronRobinsonMSFT@elinor-fung@danmoseley