Skip to content

Fix Base64 decoding regressions from whitespace handling - #86396

Merged
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:fixbase64regression
May 18, 2023
Merged

Fix Base64 decoding regressions from whitespace handling#86396
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:fixbase64regression

Conversation

@stephentoub

@stephentoubstephentoub commented May 17, 2023

Copy link
Copy Markdown
Member

Put the main code paths back to how they were before, with the sole exception being an extra method argument and an extra check in the InvalidData exit section that delegates to a helper if that method argument is true.

Fixes#86336
Fixesdotnet/perf-autofiling-issues#17837

@stephentoub
Fix Base64 decoding regressions from whitespace handling
b971ef9
Put the main code paths back to how they were before, with the sole exception being an extra method argument and an extra check in the InvalidData exit section that delegates to a helper if that method argument is true.
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 17, 2023
@stephentoub

stephentoub commented May 17, 2023

Copy link
Copy Markdown
MemberAuthor

(Note there also appears to be a stale static PGO data aspect to the cited regressions on coreclr.)

@stephentoubstephentoub added area-System.Memory and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 17, 2023
@ghost

ghost commented May 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Put the main code paths back to how they were before, with the sole exception being an extra method argument and an extra check in the InvalidData exit section that delegates to a helper if that method argument is true.

Fixes #86336
Fixes dotnet/perf-autofiling-issues#17837

Author:stephentoub
Assignees:stephentoub
Labels:

area-System.Memory, needs-area-label

Milestone:-

@stephentoub

stephentoub commented May 17, 2023

Copy link
Copy Markdown
MemberAuthor

cc: @gfoidl

gfoidl
gfoidl reviewed May 17, 2023
View reviewed changes

@gfoidlgfoidl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes, otherwise LGTM. Nice layering 👍🏻

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs Outdated
This was referenced May 17, 2023
Closed
Closed
gfoidl
gfoidl reviewed May 18, 2023
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
adamsitnik
adamsitnik approved these changes May 18, 2023
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adamsitnikadamsitnik added the tenet-performance Performance related issue label May 18, 2023
@stephentoub
stephentoub merged commit 2f18df4 into dotnet:mainMay 18, 2023
@stephentoub
stephentoub deleted the fixbase64regression branch May 18, 2023 13:21
@ghostghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes
+1 more reviewer
@gfoidlgfoidlgfoidl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoubstephentoub

Labels

area-System.Memorytenet-performancePerformance related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regressions in System.Buffers.Text.Tests.Base64EncodeDecodeInPlaceTests [Perf] Linux/x64: 2 Regressions on 5/9/2023 7:00:05 PM

3 participants

@stephentoub@gfoidl@adamsitnik