Skip to content

Ensure Vector2/3/4, Quaternion, and Plane don't have a false dependency on Vector<T> - #86481

Merged
tannergooding merged 6 commits into
dotnet:mainfrom
tannergooding:prefer-vector-width-3
May 20, 2023
Merged

Ensure Vector2/3/4, Quaternion, and Plane don't have a false dependency on Vector<T>#86481
tannergooding merged 6 commits into
dotnet:mainfrom
tannergooding:prefer-vector-width-3

Conversation

@tannergooding

@tannergoodingtannergooding commented May 19, 2023

Copy link
Copy Markdown
Member

Extracted from #85551

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 19, 2023
@ghost

ghost commented May 19, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Extracted from #85551

Author:tannergooding
Assignees:tannergooding
Labels:

area-CodeGen-coreclr

Milestone:-

tannergooding
tannergooding commented May 19, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/importercalls.cpp
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(method, &sig);

int sizeOfVectorT = getSIMDVectorRegisterByteLength();

@tannergoodingtannergoodingMay 19, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what gave the "false dependency" on all intrinsic APIs under System.Numerics.

It gave a query that was compExactlyDependsOn(InstructionSet_AVX2) which in turn meant it opted out of any default pre-jit support.

The check was instead moved down to APIs on Vector<T> itself -or- APIs that took/returned Vector<T> elsewhere.

It does not include all APIs on System.Numerics.Vector as we have a couple extension methods for Vector2/3/4, Quaternion, and Plane that live on the same class

@build-analysisbuild-analysisBot mentioned this pull request May 19, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request May 19, 2023
Closed
@tannergooding
tannergoodingforce-pushed the prefer-vector-width-3 branch from 8c0caf6 to 038796aCompareMay 19, 2023 18:54
@build-analysisbuild-analysisBot mentioned this pull request May 19, 2023
Closed
@tannergoodingtannergooding mentioned this pull request May 20, 2023
Closed
3 tasks
@tannergooding

tannergooding commented May 20, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Failure is dotnet/arcade#13625 and reproducing on other PRs

@tannergooding
tannergooding merged commit d7a30ba into dotnet:mainMay 20, 2023
@tannergooding
tannergooding deleted the prefer-vector-width-3 branch May 20, 2023 01:59
@kotlarmiloskotlarmilos mentioned this pull request May 24, 2023
Closed
@radekdoulikradekdoulik mentioned this pull request May 31, 2023
Open
@kotlarmiloskotlarmilos mentioned this pull request Jun 2, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tannergooding@EgorBo