[main] Update dependencies from dotnet/arcade - #86494

Merged
ViktorHofer merged 10 commits into
mainfrom
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged

[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom
darc-main-4788e293-2d09-49c7-8768-0ab101c71752

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented May 19, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost added the area-codeflow for labeling automated codeflow label May 19, 2023
This was referenced May 19, 2023
Open
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing added the source-build Issues relating to dotnet/source-build label May 23, 2023
@lewing

lewing commented May 23, 2023

Copy link
Copy Markdown
Member

cc @dotnet/source-build-contrib

@ViktorHofer

ViktorHofer commented May 23, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Will take a look. Related to my change in Arcade.

@ViktorHofer

ViktorHofer commented May 24, 2023

Copy link
Copy Markdown
Member

@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):

Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)

Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.

@ViktorHoferViktorHofer added the blocked Issue/PR is blocked on something - see comments label May 24, 2023
@ViktorHoferViktorHofer mentioned this pull request May 24, 2023
Merged
@MichaelSimons

MichaelSimons commented May 24, 2023

Copy link
Copy Markdown
Member

@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):

Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)

Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.

This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.

@oleksandr-didyk

oleksandr-didyk commented May 24, 2023

Copy link
Copy Markdown
Contributor

A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP

But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?

@MichaelSimons

MichaelSimons commented May 24, 2023

Copy link
Copy Markdown
Member

But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?

Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.

When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.

@oleksandr-didyk

oleksandr-didyk commented May 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.

Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1

@ViktorHofer

ViktorHofer commented May 24, 2023

Copy link
Copy Markdown
Member

This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.

I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?

@MichaelSimons

MichaelSimons commented May 24, 2023

Copy link
Copy Markdown
Member

This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.

I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?

Correct.

@ViktorHoferViktorHofer mentioned this pull request May 24, 2023
Closed
@ViktorHofer

ViktorHofer commented May 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Blocked by dotnet/arcade#13681

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk mentioned this pull request May 25, 2023
Merged
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot mentioned this pull request May 26, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request May 26, 2023
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot mentioned this pull request May 27, 2023
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot mentioned this pull request May 29, 2023
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky mentioned this pull request May 30, 2023
Merged
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer removed the blocked Issue/PR is blocked on something - see comments label May 30, 2023
@ViktorHofer
ViktorHofer merged commit 1345190 into mainMay 31, 2023
@ViktorHofer
ViktorHofer deleted the darc-main-4788e293-2d09-49c7-8768-0ab101c71752 branch May 31, 2023 05:16
@ghostghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[main] Update dependencies from dotnet/arcade - #86494
Merged
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
May 31, 2023
Merged
[main] Update dependencies from dotnet/arcade#86494
ViktorHofer merged 10 commits into
mainfrom 
darc-main-4788e293-2d09-49c7-8768-0ab101c71752
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
May 19, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230530.1
  • Date Produced: May 30, 2023 2:56:32 PM UTC
  • Commit: affe3f66d36e48946fd59ac9fa31b004cb558e7d
  • Branch: refs/heads/main
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency

attribute were produced in a build used as input to the parent dependency's build.

See Dependency Description Format
  • Coherency Updates:

    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23266.1 to 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk)
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
be5ebee
…519.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
May 19, 2023

This was referenced May 19, 2023

Open


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f8db49b
…519.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23269.2
@lewinglewing
added
the 
source-build
Issues relating to dotnet/source-build
label
May 23, 2023
@lewing
lewing
commented
May 23, 2023

Copy link


Copy Markdown

Member
cc @dotnet/source-build-contrib
@ViktorHofer
ViktorHofer
commented
May 23, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Will take a look. Related to my change in Arcade.
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
@ViktorHoferViktorHofer
added
the 
blocked
Issue/PR is blocked on something - see comments
label
May 24, 2023
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023
 Merged

@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
@MichaelSimons@mthalman@oleksandr-didyk I need help with understanding this issue (https://dev.azure.com/dnceng-public/public/_build/results?buildId=280839&view=logs&jobId=e4a6e402-3c79-58b1-6b2c-6d6de3128627&j=e4a6e402-3c79-58b1-6b2c-6d6de3128627&t=4977add1-8c56-5a7c-efa0-f1d583109a84):
Could not load file or assembly 'Microsoft.CodeAnalysis, Version=4.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL'. Reference assemblies cannot be loaded for execution. (0x80131058)
Why does GenFacades use a Microsoft.CodeAnalysis from SBRP? I would expect it to use the N-1.
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP. Please open an issue. This would likely surface in the source-build product build with dotnet/installer#16111.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023

Copy link


Copy Markdown

Contributor
A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
But wouldn't this hold true only for the product build? When building the intermediate, Arcade would still use 4.4.0 from SBRP, no?
Not with the per repo pvp work coming in with dotnet/installer#16111. With that work, we will only lift the dependencies specified in the version.details.xml. If the dependency isn't specified, source-build will use what the repo has specified, meaning an SBRP will be utilized.
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
@oleksandr-didyk
oleksandr-didyk
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
When building the source-build repo leg, if the dependency is declared in the version.details.xml, it will pull in the intermediate (e.g. N-1). If the dependency is not declared, an SBRP will be used.
Oh, my bad, I for some reason thought you meant declaring it in Version.Details.xml with the 4.4.0 version instead of N-1
@ViktorHofer
ViktorHofer
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
@MichaelSimons
MichaelSimons
commented
May 24, 2023

Copy link


Copy Markdown

Member
This sounds like a regression caused from the prebuilt work. A Version.Details.xml dependency should be added so the N-1 version is used versus an SBRP.
I assume this needs to be done in arcade so that the N-1 Microsoft.CodeAnalysis is used when building Microsoft.DotNet.GenFacades?
Correct.
@ViktorHoferViktorHofer
mentioned this pull request
May 24, 2023

Closed

@ViktorHofer
ViktorHofer
commented
May 24, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Blocked by dotnet/arcade#13681
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
8dfb616
…524.6
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23274.6
@oleksandr-didykoleksandr-didyk
mentioned this pull request
May 25, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
f056996
…525.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23275.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@runfoapprunfoappBot
mentioned this pull request
May 26, 2023

Closed

@build-analysisbuild-analysisBot
mentioned this pull request
May 26, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
7610bf5
…526.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23276.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 27, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
ac7ddcf
…527.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23277.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
df6d2ac
…529.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@build-analysisbuild-analysisBot
mentioned this pull request
May 29, 2023

Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
60dd4f5
…529.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23279.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@jkoritzinskyjkoritzinsky
mentioned this pull request
May 30, 2023
 Merged

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20230…
34535af
…530.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23268.1 -> To Version 8.0.0-beta.23280.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23266.1 -> To Version 1.0.0-beta.23272.1 (parent: Microsoft.DotNet.Arcade.Sdk
@ViktorHoferViktorHofer
removed
the 
blocked
Issue/PR is blocked on something - see comments
label
May 30, 2023
@ViktorHofer
ViktorHofer
merged commit 1345190
into
mainMay 31, 2023
@ViktorHofer
ViktorHofer
deleted the

darc-main-4788e293-2d09-49c7-8768-0ab101c71752

branch
May 31, 2023 05:16
@ghostghost
locked as resolved and limited conversation to collaborators
Jun 30, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflowsource-buildIssues relating to dotnet/source-build

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ViktorHofer@MichaelSimons@oleksandr-didyk