Skip to content

[mono][tests] Run Mono iOS sample as functional test on the simulator and maccatalyst on Helix - #86578

Merged
kotlarmilos merged 31 commits into
dotnet:mainfrom
kotlarmilos:feature/ios-sample-helix
Jun 11, 2023
Merged

[mono][tests] Run Mono iOS sample as functional test on the simulator and maccatalyst on Helix#86578
kotlarmilos merged 31 commits into
dotnet:mainfrom
kotlarmilos:feature/ios-sample-helix

Conversation

@kotlarmilos

@kotlarmiloskotlarmilos commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This PR adds Mono iOS app as a functional test on the simulator and maccatalyst to the Helix.

/cc: @ivanpovazan@filipnavara

@kotlarmiloskotlarmilos added this to the 8.0.0 milestone May 22, 2023
@kotlarmiloskotlarmilos self-assigned this May 22, 2023
@ghost

ghost commented May 22, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR enables Mono iOS sample on Helix. Additionally, it aims to enable/test the Native AOT sample on Helix.

Author:kotlarmilos
Assignees:kotlarmilos
Labels:

area-Infrastructure-mono

Milestone:8.0.0

This was referenced May 22, 2023
Closed
Closed
@kotlarmilos

kotlarmilos commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented May 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented May 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike

@azure-pipelines

azure-pipelinesBot commented May 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented May 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos

kotlarmilos commented May 23, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike,runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented May 23, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request May 24, 2023
Closed
@kotlarmilos

kotlarmilos commented May 24, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented May 24, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented May 25, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented May 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos
kotlarmilos marked this pull request as ready for review May 25, 2023 12:18
ivanpovazan
ivanpovazan reviewed Jun 6, 2023
View reviewed changes
Comment threadsrc/libraries/tests.proj Outdated
ivanpovazan
ivanpovazan reviewed Jun 6, 2023
View reviewed changes
Comment threadsrc/libraries/tests.proj Outdated
@kotlarmiloskotlarmilos changed the title [mono][tests] Run Mono iOS sample as functional test on Helix[mono][tests] Run Mono iOS sample as functional test on the simulator and maccatalyst on HelixJun 6, 2023
ivanpovazan
ivanpovazan reviewed Jun 6, 2023
View reviewed changes
Comment threadsrc/mono/sample/iOS/Program.csproj Outdated
@kotlarmilos

kotlarmilos commented Jun 6, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

This comment was marked as off-topic.

Sign in to view
@azure-pipelines

azure-pipelinesBot commented Jun 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kotlarmilos

kotlarmilos commented Jun 7, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslikesimulator

@azure-pipelines

azure-pipelinesBot commented Jun 7, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Jun 8, 2023
Closed
ivanpovazan
ivanpovazan approved these changes Jun 8, 2023
View reviewed changes

@ivanpovazanivanpovazan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

I just added a small note in the review, but is not a blocker.

Comment threadsrc/mono/sample/iOS/Program.csproj
Comment threadsrc/mono/sample/iOS/Program.csproj Outdated
This was referenced Jun 8, 2023
Closed
Closed
@kotlarmilos

kotlarmilos commented Jun 10, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jun 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@kotlarmilos

kotlarmilos commented Jun 10, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-maccatalyst

@azure-pipelines

azure-pipelinesBot commented Jun 10, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jun 10, 2023
Closed
Closed
Closed
Closed
Closed
@kotlarmilos

kotlarmilos commented Jun 11, 2023

Copy link
Copy Markdown
MemberAuthor

The tests are passing locally and on the CI. @ivanpovazan Thank you for valuable feedback!

@kotlarmilos
kotlarmilos merged commit 19712d9 into dotnet:mainJun 11, 2023
@ghostghost locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ivanpovazanivanpovazanivanpovazan approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@steveisoksteveisokAwaiting requested review from steveisoksteveisok is a code owner
+1 more reviewer
@filipnavarafilipnavarafilipnavara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kotlarmiloskotlarmilos

Labels

area-Infrastructure-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kotlarmilos@steveisok@filipnavara@ivanpovazan