Skip to content

[NativeAOT] Handle event pipe environment variable configuration and output to file - #86656

Merged
elinor-fung merged 7 commits into
dotnet:mainfrom
elinor-fung:nativeaot-eventpipe-config
May 25, 2023
Merged

[NativeAOT] Handle event pipe environment variable configuration and output to file#86656
elinor-fung merged 7 commits into
dotnet:mainfrom
elinor-fung:nativeaot-eventpipe-config

Conversation

@elinor-fung

@elinor-fungelinor-fung commented May 23, 2023

Copy link
Copy Markdown
Member

Updates to NativeAOT event pipe:

  • Respect environment variable configuration
  • Handle writing out to a file
  • Enable tracing/eventpipe/config/name_config_with_pid test, which uses environment variable configuration to write directly to a file.

Also some tweaks to headers to reduce some of the assumptions they have about what is/isn't included already.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Updates to NativeAOT event pipe:

  • Respect environment variable configuration
  • Handle writing out to a file for Windows - the TODO remains for non-Windows
  • Enable tracing/eventpipe/config/name_config_with_pid test, which uses environment variable configuration to write directly to a file.

Also some tweaks to headers to reduce some of the assumptions they have about what is/isn't included already.

Author:elinor-fung
Assignees:-
Labels:

area-NativeAOT-coreclr

Milestone:-

Comment threadsrc/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.h Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/windows/PalRedhawkMinWin.cpp Outdated
Comment threadsrc/tests/tracing/eventpipe/config/name_config_with_pid.csproj Outdated
@elinor-fungelinor-fung changed the title [NativeAOT] Handle event pipe environment variable configuration and output to file on Windows[NativeAOT] Handle event pipe environment variable configuration and output to fileMay 24, 2023
Comment threadsrc/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp Outdated
@elinor-fung

Copy link
Copy Markdown
MemberAuthor

Verified that the newly enabled test is running/passing in CI.
name_config_with_pid result: log
PayloadGroup0 now has three tracing tests enabled: log

@LakshanFLakshanF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding both environment variable and file support on all platforms!

@elinor-fung
elinor-fung merged commit 12a7bda into dotnet:mainMay 25, 2023
@elinor-fung
elinor-fung deleted the nativeaot-eventpipe-config branch May 25, 2023 19:40
@ghostghost locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@elinor-fung@jkotas@LakshanF